You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
assignee='https://github.com/DinoV'closed_at=<Date2020-01-23.00:57:27.184>created_at=<Date2020-01-14.21:33:31.500>labels= ['interpreter-core', 'type-bug']
title="Immutable module type can't be used as package in custom loader"updated_at=<Date2020-01-28.02:21:01.711>user='https://github.com/DinoV'
I'm trying to create a custom module type for a custom loader where the returned modules are immutable. But I'm running into an issue where the immutable module type can't be used as a module for a package. That's because the import machinery calls setattr to set the module as an attribute on it's parent in _boostrap.py
# Set the module as an attribute on its parent.parent_module=sys.modules[parent]
setattr(parent_module, name.rpartition('.'), module)
I'd be okay if for these immutable module types they simply didn't have their children packages published on them.
A simple simulation of this is a package which replaces its self with an object which doesn't support adding arbitrary attributes:
>>> from x import y
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "<frozen importlib._bootstrap>", line 983, in _find_and_load
File "<frozen importlib._bootstrap>", line 971, in _find_and_load_unlocked
AttributeError: 'MyMod' object has no attribute 'y'
There's a few different options I could see on how this could be supported:
1) Simply handle the attribute error and allow things to continue
2) Add ability for the modules loader to perform the set, and fallback to setattr if one isn't available. Such as:
getattr(parent_module, 'add_child_module', setattr)(parent_module, name.rpartition('.'), module)
3) Add the ability for the module type to handle the setattr:
getattr(type(parent_module), 'add_child_module', fallback)(parent_module,
, name.rpartition('.'), module)
I think the warning shouldn't be too bad. It looks like ImportWarnings are filtered by default already, and the extra overhead of raising a warning in this case probably is nothing compared to the actual work in loading the module.