zipfile: add missing "pwd: expected bytes, got str" exception message

[danifus]

BPO	39359
Nosy	@Yhg1s, @ambv, @serhiy-storchaka, @danifus
PRs	bpo-39359, zipfile: add missing "pwd: expected bytes, got str" exception #18031

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-09-23.21:38:18.710>
created_at = <Date 2020-01-16.13:20:14.781>
labels = ['type-feature', 'library', '3.11']
title = 'zipfile: add missing "pwd: expected bytes, got str" exception message'
updated_at = <Date 2021-09-27.12:45:59.826>
user = 'https://github.com/danifus'

bugs.python.org fields:

activity = <Date 2021-09-27.12:45:59.826>
actor = 'dhillier'
assignee = 'none'
closed = True
closed_date = <Date 2021-09-23.21:38:18.710>
closer = 'lukasz.langa'
components = ['Library (Lib)']
creation = <Date 2020-01-16.13:20:14.781>
creator = 'dhillier'
dependencies = []
files = []
hgrepos = []
issue_num = 39359
keywords = ['patch']
message_count = 6.0
messages = ['360118', '402530', '402531', '402539', '402702', '402705']
nosy_count = 4.0
nosy_names = ['twouters', 'lukasz.langa', 'serhiy.storchaka', 'dhillier']
pr_nums = ['18031']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue39359'
versions = ['Python 3.11']

[danifus]

Setting the ZipFile.pwd attribute directly skips the check to ensure the password is a bytes object and, if not, return a user friendly TypeError("pwd: expected bytes, got <type>") informing them of that.

[ambv]

New changeset 91099e2 by Daniel Hillier in branch 'main':
bpo-39359: [zipfile] add missing "pwd: expected bytes, got str" exception (GH-18031)
91099e2

[ambv]

Thanks, Daniel! ✨ 🍰 ✨

[danifus]

Thanks Łukasz!

[serhiy-storchaka]

Why do you set the ZipFile.pwd attribute directly?

[danifus]

I agree it is bad form but I would accidentally do it when I couldn't remember the proper API and took a stab in the dark without looking up the docs. I unfortunately used it in an example in the docs for pyzipper and started getting a few bug reports even after fixing my docs.