-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gzip metadata fails to reflect compresslevel #83570
Comments
The Repro:
Run this script, then run
The file sizes correctly reflect the difference, but The error is that the ninth byte of the header in the output stream is Using GNU |
(The commit reference above was meant to be git558f07891170, not a |
Looks reasonable. gzip should write b'\002' for compresslevel == _COMPRESS_LEVEL_BEST, b'\004' for compresslevel == _COMPRESS_LEVEL_FAST, and b'\000' otherwise. Do you mind to create a PR William. |
Sure, PR sent (pull_request17470). |
PR URL, for reference: |
Thank you for your contribution William! |
My pleasure; thanks for the triage and review! |
Ping. The 3.7.x backport (PR 18101) for this issue is still open and neither needs to be fixed or closed. |
"either" |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: