Implement PEP 585 (Type Hinting Generics In Standard Collections) #83662

gvanrossum · 2020-01-28T17:16:58Z

BPO	39481
Nosy	@gvanrossum, @ambv, @serhiy-storchaka, @ethanhs, @miss-islington, @isidentical, @gousaiyang
PRs	bpo-39481: Implementation for PEP 585 #18239 bpo-39481: Generic alias to os.DirEntry #19415 bpo-39481: Generic alias for itertools.chain #19417 bpo-39481: Add GenericAlias support to ipaddress.py #19418 bpo-39481: Make enumerate, AsyncGeneratorType, mmap generic #19421 bpo-39481: PEP 585 for difflib, filecmp, fileinput #19422 bpo-39481: PEP 585 for a variety of modules #19423 bpo-39481: Make dataclasses.Field, contextvars.Token, ... #19425 bpo-39481: Make functools.cached_property, partial, ... #19427 bpo-39481: Generic alias support to ctypes.Array, LibraryLoader... #19434 bpo-39481: Generic alias support to mp.ValueProxy, mp.ApplyResult, mp… #19435 bpo-39481: fix test_genericalias on Android #19469 bpo-39481: Make weakref and WeakSet generic #19497 bpo-39481: remove generic classes from ipaddress/mmap #20045 bpo-39481: Fix duplicate SimpleQueue type in test_genericalias.py #22619 [3.9] bpo-39481: Fix duplicate SimpleQueue type in test_genericalias.py (GH-22619) #22624

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-07-25.21:57:06.912>
created_at = <Date 2020-01-28.17:16:57.906>
labels = ['interpreter-core', 'type-bug', '3.9']
title = 'Implement PEP 585 (Type Hinting Generics In Standard Collections)'
updated_at = <Date 2020-10-12.23:52:11.592>
user = 'https://github.com/gvanrossum'

bugs.python.org fields:

activity = <Date 2020-10-12.23:52:11.592>
actor = 'gvanrossum'
assignee = 'none'
closed = True
closed_date = <Date 2020-07-25.21:57:06.912>
closer = 'gvanrossum'
components = ['Interpreter Core']
creation = <Date 2020-01-28.17:16:57.906>
creator = 'gvanrossum'
dependencies = []
files = []
hgrepos = []
issue_num = 39481
keywords = ['patch']
message_count = 29.0
messages = ['360885', '364311', '365357', '365914', '365916', '365936', '365943', '365949', '366102', '366104', '366105', '366106', '366108', '366109', '366131', '366288', '366309', '366311', '366333', '366366', '366367', '366464', '366468', '366476', '367244', '368697', '374286', '378343', '378535']
nosy_count = 7.0
nosy_names = ['gvanrossum', 'lukasz.langa', 'serhiy.storchaka', 'ethan smith', 'miss-islington', 'BTaskaya', 'gousaiyang']
pr_nums = ['18239', '19415', '19417', '19418', '19421', '19422', '19423', '19425', '19427', '19434', '19435', '19469', '19497', '20045', '22619', '22624']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue39481'
versions = ['Python 3.9']

gvanrossum · 2020-01-28T17:16:58Z

See PEP-585, which is still under review and may change in response to this work.

https://www.python.org/dev/peps/pep-0585/

ambv · 2020-03-16T11:17:19Z

Submitted a request for consideration by the Steering Council: python/steering-council#21

gvanrossum · 2020-03-30T21:38:02Z

The SC approved the PEP!

Łukasz, do you want to submit the PR to update the PEP status?

We should get the implementation reviewed (e.g. by Serhiy) and land it before alpha 6 goes out, April 22 (we should aim for a week before at least).

gvanrossum · 2020-04-07T16:50:09Z

New changeset 48b069a by Guido van Rossum in branch 'master':
bpo-39481: Implementation for PEP-585 (bpo-18239)
48b069a

gvanrossum · 2020-04-07T16:51:56Z

The base implementation has landed. We still need docs, and I'm sure that the alpha and beta release cycle will find small things that need to be improved.

Perhaps the next priority is an update for Doc/whatsnew/3.9.rst.

isidentical · 2020-04-07T20:35:46Z

@gvanrossum is new types going to support generic alias protocol or this subset will be kept? Like typeshed uses os.DirEntry as a generic, but in reality it is not. (#17561)

gvanrossum · 2020-04-07T20:57:51Z

Ethan Smith produced a list of types that are Generic in typeshed but not in the stdlib. So these could be added.

gvanrossum#1 (comment)

gvanrossum · 2020-04-07T21:37:23Z

New changeset f9dd51e by Batuhan Taşkaya in branch 'master':
bpo-39481: Make os.DirEntry generic (GH-19415)
f9dd51e

gvanrossum · 2020-04-10T04:05:01Z

New changeset 2fa67df by Batuhan Taşkaya in branch 'master':
bpo-39481: PEP-585 for ipaddress.py (GH-19418)
2fa67df

gvanrossum · 2020-04-10T04:26:00Z

New changeset 7c4185d by Ethan Smith in branch 'master':
bpo-39481: PEP-585 for enumerate, AsyncGeneratorType, mmap (GH-19421)
7c4185d

gvanrossum · 2020-04-10T04:34:18Z

At this speed I can merge about 3 PRs per hour. I'll be back tomorrow.

gvanrossum · 2020-04-10T04:47:38Z

New changeset e3ec44d by Ethan Smith in branch 'master':
bpo-39481: PEP-585 for difflib, filecmp, fileinput (bpo-19422)
e3ec44d

serhiy-storchaka · 2020-04-10T05:08:53Z

How are ipaddress and mmap generic?

gvanrossum · 2020-04-10T05:10:21Z

Check typeshed

gvanrossum · 2020-04-10T14:46:43Z

New changeset 0361556 by Batuhan Taşkaya in branch 'master':
bpo-39481: PEP-585 for a variety of modules (GH-19423)
0361556

serhiy-storchaka · 2020-04-13T09:12:30Z

I tested the following example:

import ipaddress, mmap

x: ipaddress.IPv4Network[int]
y: mmap.mmap[int]

MyPy produces errors:

t.py:4: error: "IPv4Network" expects no type arguments, but 1 given
t.py:5: error: "mmap" expects no type arguments, but 1 given

This is because mmap and IPv4Network are not generic types in typeshed. _BaseNetwork and _mmap are generic types, but IPv4Network and mmap are normal classes. The former are implementation detail of typeshed. _mmap does not exist in the stdlib, and _BaseNetwork in typeshed and the stdlib are different things.

ethanhs · 2020-04-13T12:36:57Z

Hm, yeah it appears my methodology was too loose. Thank you for catching
these. I will go through and test the rest (if you haven't yet) later today
and make a PR to revert anything that needs it. Thanks! (and sorry)

On Mon, Apr 13, 2020 at 2:12 AM Serhiy Storchaka <report@bugs.python.org>
wrote:

Serhiy Storchaka <storchaka+cpython@gmail.com> added the comment:

I tested the following example:

import ipaddress, mmap

x: ipaddress.IPv4Network[int]
y: mmap.mmap[int]

MyPy produces errors:

t.py:4: error: "IPv4Network" expects no type arguments, but 1 given
t.py:5: error: "mmap" expects no type arguments, but 1 given

This is because mmap and IPv4Network are not generic types in typeshed.
_BaseNetwork and _mmap are generic types, but IPv4Network and mmap are
normal classes. The former are implementation detail of typeshed. _mmap
does not exist in the stdlib, and _BaseNetwork in typeshed and the stdlib
are different things.

----------

Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue39481\>

serhiy-storchaka · 2020-04-13T12:52:36Z

No, I did not check other changes. These two just looked too suspicious.

gvanrossum · 2020-04-13T22:00:31Z

New changeset 25a6833 by Chih-Hsuan Yen in branch 'master':
bpo-39481: fix test_genericalias on Android (GH-19469)
25a6833

gvanrossum · 2020-04-14T04:53:11Z

New changeset cecf049 by Ethan Smith in branch 'master':
bpo-39481: Make functools.cached_property, partial, partialmethod generic (bpo-19427)
cecf049

gvanrossum · 2020-04-14T04:54:43Z

New changeset 8ef8750 by Ethan Smith in branch 'master':
bpo-39481: Make weakref and WeakSet generic (GH-19497)
8ef8750

gvanrossum · 2020-04-14T23:14:22Z

New changeset d01628e by Ethan Smith in branch 'master':
bpo-39481: PEP-585 for dataclasses, mailbox, contextvars (GH-19425)
d01628e

ethanhs · 2020-04-15T00:46:25Z

I went through the list I generated and it seems that the
ipaddress._BaseNetwork and mmap.mmap cases are the only one I saw that
shouldn't be generic. I will submit a PR to revert those. The only item
left after that which I know of is _lru_cache_wrapper.

On Tue, Apr 14, 2020 at 4:14 PM Guido van Rossum <report@bugs.python.org>
wrote:

Guido van Rossum <guido@python.org> added the comment:

New changeset d01628e by Ethan Smith in
branch 'master':
bpo-39481: PEP-585 for dataclasses, mailbox, contextvars (GH-19425)

d01628e

----------

Python tracker <report@bugs.python.org>
<https://bugs.python.org/issue39481\>

gvanrossum · 2020-04-15T01:59:14Z

Thanks!

--Guido (mobile)

gvanrossum · 2020-04-25T00:20:56Z

In commit 0e80b56 a What's New section was added.

gvanrossum · 2020-05-12T02:32:47Z

New changeset f3a5b7a by Batuhan Taskaya in branch 'master':
bpo-39481: remove generic classes from ipaddress/mmap (GH-20045)
f3a5b7a

gvanrossum · 2020-07-25T21:57:07Z

This can be closed. It needs docs though; there's a separate issue for that (bpo-40814).

miss-islington · 2020-10-09T20:00:28Z

New changeset b2c0a43 by Saiyang Gou in branch 'master':
bpo-39481: Fix duplicate SimpleQueue type in test_genericalias.py (GH-22619)
b2c0a43

gvanrossum · 2020-10-12T23:52:12Z

New changeset 1c21765 by Saiyang Gou in branch '3.9':
[3.9] bpo-39481: Fix duplicate SimpleQueue type in test_genericalias.py (GH-22619) (bpo-22624)
1c21765

gvanrossum added 3.9 only security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error labels Jan 28, 2020

gvanrossum closed this as completed Jul 25, 2020

ezio-melotti transferred this issue from another repository Apr 10, 2022

DanielNoord mentioned this issue May 23, 2022

Permit subscripting additional builtin classes pylint-dev/astroid#1572

Merged

cfbolz mentioned this issue Dec 3, 2024

add __class_getitem__ to the python implementation of functools.partial #127537

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement PEP 585 (Type Hinting Generics In Standard Collections) #83662

Implement PEP 585 (Type Hinting Generics In Standard Collections) #83662

gvanrossum commented Jan 28, 2020

gvanrossum commented Jan 28, 2020

ambv commented Mar 16, 2020

gvanrossum commented Mar 30, 2020

gvanrossum commented Apr 7, 2020

gvanrossum commented Apr 7, 2020

isidentical commented Apr 7, 2020

gvanrossum commented Apr 7, 2020

gvanrossum commented Apr 7, 2020

gvanrossum commented Apr 10, 2020

gvanrossum commented Apr 10, 2020

gvanrossum commented Apr 10, 2020

gvanrossum commented Apr 10, 2020

serhiy-storchaka commented Apr 10, 2020

gvanrossum commented Apr 10, 2020

gvanrossum commented Apr 10, 2020

serhiy-storchaka commented Apr 13, 2020

ethanhs mannequin commented Apr 13, 2020

serhiy-storchaka commented Apr 13, 2020

gvanrossum commented Apr 13, 2020

gvanrossum commented Apr 14, 2020

gvanrossum commented Apr 14, 2020

gvanrossum commented Apr 14, 2020

ethanhs mannequin commented Apr 15, 2020

gvanrossum commented Apr 15, 2020

gvanrossum commented Apr 25, 2020

gvanrossum commented May 12, 2020

gvanrossum commented Jul 25, 2020

miss-islington commented Oct 9, 2020

gvanrossum commented Oct 12, 2020

Implement PEP 585 (Type Hinting Generics In Standard Collections) #83662

Implement PEP 585 (Type Hinting Generics In Standard Collections) #83662

Comments

gvanrossum commented Jan 28, 2020

gvanrossum commented Jan 28, 2020

ambv commented Mar 16, 2020

gvanrossum commented Mar 30, 2020

gvanrossum commented Apr 7, 2020

gvanrossum commented Apr 7, 2020

isidentical commented Apr 7, 2020

gvanrossum commented Apr 7, 2020

gvanrossum commented Apr 7, 2020

gvanrossum commented Apr 10, 2020

gvanrossum commented Apr 10, 2020

gvanrossum commented Apr 10, 2020

gvanrossum commented Apr 10, 2020

serhiy-storchaka commented Apr 10, 2020

gvanrossum commented Apr 10, 2020

gvanrossum commented Apr 10, 2020

serhiy-storchaka commented Apr 13, 2020

ethanhs mannequin commented Apr 13, 2020

serhiy-storchaka commented Apr 13, 2020

gvanrossum commented Apr 13, 2020

gvanrossum commented Apr 14, 2020

gvanrossum commented Apr 14, 2020

gvanrossum commented Apr 14, 2020

ethanhs mannequin commented Apr 15, 2020

gvanrossum commented Apr 15, 2020

Thanks!

gvanrossum commented Apr 25, 2020

gvanrossum commented May 12, 2020

gvanrossum commented Jul 25, 2020

miss-islington commented Oct 9, 2020

gvanrossum commented Oct 12, 2020