-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uuid.getnode() has unused argument #83740
Comments
uuid.getnode() has an undocumented, keyword-only "getters" argument that gets discarded immediately. This is confusing when using code inspection tools and can give the wrong impression that you can somehow override the node getters when you can't. I recommend removing this argument. |
Shantanu points out in python/typeshed#3715 that the argument was made useless due to bpo-28009. |
Simply removing the argument would be backwards-incompatible. Unless someone can show via a code search that this is never used in practice, we may want to consider deprecating this argument before removing it. |
Github code search isn't great, but I was unable to find any usage of Let me know what you think should be done; happy to submit a PR that issues a deprecation warning. |
Code using this argument is in all likelihood already subtly broken, because it depends on non-existing functionality. I believe that a "hard" break would be better (for Python 3.9). |
I agree. It was added in bpo-32502, but was never documented and used. Thank you Sebastian and Shantanu. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: