Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnings.py should not raise AssertionError when validating arguments #84093

Closed
remilapeyre mannequin opened this issue Mar 9, 2020 · 1 comment
Closed

warnings.py should not raise AssertionError when validating arguments #84093

remilapeyre mannequin opened this issue Mar 9, 2020 · 1 comment
Labels
3.9 only security fixes stdlib Python modules in the Lib dir

Comments

@remilapeyre
Copy link
Mannequin

remilapeyre mannequin commented Mar 9, 2020

BPO 39912
Nosy @remilapeyre
PRs
  • bpo-39912: Raise appropriate exceptions in filterwarnings() and simplefilter() #18878
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-03-09.14:05:44.963>
    labels = ['library', '3.9']
    title = 'warnings.py should not raise AssertionError when validating arguments'
    updated_at = <Date 2020-03-09.14:15:03.051>
    user = 'https://github.com/remilapeyre'

    bugs.python.org fields:

    activity = <Date 2020-03-09.14:15:03.051>
    actor = 'remi.lapeyre'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2020-03-09.14:05:44.963>
    creator = 'remi.lapeyre'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 39912
    keywords = ['patch']
    message_count = 1.0
    messages = ['363732']
    nosy_count = 1.0
    nosy_names = ['remi.lapeyre']
    pr_nums = ['18878']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue39912'
    versions = ['Python 3.9']

    @remilapeyre
    Copy link
    Mannequin Author

    remilapeyre mannequin commented Mar 9, 2020

    Currently simplefilter() and filterwarnings() don't validate their arguments when using -O and AssertionError is not the most appropriate exception to raise.

    I will post a PR shortly.

    @remilapeyre remilapeyre mannequin added 3.9 only security fixes stdlib Python modules in the Lib dir labels Mar 9, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant