Embedded installer for Python 3.7.7 missing vcruntime140.dll

[freakboy3742]

BPO	39930
Nosy	@pfmoore, @vstinner, @tjguk, @freakboy3742, @zware, @zooba, @miss-islington
PRs	bpo-39930: Ensure vcruntime140.dll is included in all Windows packages #18918 [3.8] bpo-39930: Ensure vcruntime140.dll is included in all Windows packages (GH-18918) #18919 [3.7] bpo-39930: Ensure vcruntime140.dll is included in all Windows packages (GH-18918) #18920 bpo-39930: Convert error to warning for more silent failure #18921 [3.7] bpo-39930: Convert error to warning for more silent failure (GH-18921) #18922 [3.8] bpo-39930: Convert error to warning for more silent failure (GH-18921) #18923 bpo-39930: Fix MSBuild detection for Build Tools #18938 [3.8] bpo-39930: Fix MSBuild detection for Build Tools (GH-18938) #18943 [3.7] bpo-39930: Fix MSBuild detection for Build Tools (GH-18938) #18962

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2020-03-13.15:55:47.497>
created_at = <Date 2020-03-11.09:19:34.923>
labels = ['build', '3.7', 'OS-windows']
title = 'Embedded installer for Python 3.7.7 missing vcruntime140.dll'
updated_at = <Date 2020-03-13.15:55:47.496>
user = 'https://github.com/freakboy3742'

bugs.python.org fields:

activity = <Date 2020-03-13.15:55:47.496>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2020-03-13.15:55:47.497>
closer = 'steve.dower'
components = ['Build', 'Windows']
creation = <Date 2020-03-11.09:19:34.923>
creator = 'freakboy3742'
dependencies = []
files = []
hgrepos = []
issue_num = 39930
keywords = ['patch']
message_count = 19.0
messages = ['363891', '363895', '363897', '363904', '363905', '363907', '363908', '363913', '363917', '363918', '363919', '363920', '363921', '363922', '363923', '363982', '363985', '364029', '364079']
nosy_count = 7.0
nosy_names = ['paul.moore', 'vstinner', 'tim.golden', 'freakboy3742', 'zach.ware', 'steve.dower', 'miss-islington']
pr_nums = ['18918', '18919', '18920', '18921', '18922', '18923', '18938', '18943', '18962']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue39930'
versions = ['Python 3.7']

[freakboy3742]

The Windows python-3.7.7-embed-amd64.zip installer (released Mar 11 2020) appears to be missing vcruntime140.dll. As a result, running the python.exe or pythonw.exe included in that installer fails with a system error notifying you of the missing DLL.

The 3.7.6 embedded install included this file.

[freakboy3742]

It appears the 3.7.7RC1 embedded installer was also missing the file.

[zooba]

Thanks for the heads-up, I'll take a look.

[zooba]

New changeset 2dd4174 by Steve Dower in branch 'master':
bpo-39930: Ensure vcruntime140.dll is included in all Windows packages (GH-18918)
2dd4174

[miss-islington]

New changeset d01c550 by Miss Islington (bot) in branch '3.8':
bpo-39930: Ensure vcruntime140.dll is included in all Windows packages (GH-18918)
d01c550

[vstinner]

AMD64 Windows10 3.8 build failed with "(...)\pyproject.props(221,5): error : vcruntime14*.dll not found (...)":
https://buildbot.python.org/all/#builders/159/builds/190

[vstinner]

Same error on AMD64 Windows10 3.x:
https://buildbot.python.org/all/#builders/129/builds/513

[zooba]

New changeset eede148 by Steve Dower in branch '3.7':
bpo-39930: Ensure vcruntime140.dll is included in all Windows packages (GH-18918)
eede148

[zooba]

Ah, both of those buildbots are running Build Tools. Apparently there's a different layout for those.

Note that the devguide provides instructions that can't be followed with the Build Tools - you need VS Community (at least): https://devguide.python.org/setup/#windows

Hopefully by tonight I'll have proper work access so I can figure out why Build Tools don't install everything. It may just be that a configuration option was missed, and so the buildbot owners will have to modify their install.

[vstinner]

Other examples of failures.

AMD64 Windows8.1 Non-Debug 3.x:
https://buildbot.python.org/all/#/builders/9/builds/473

     D:\buildarea\3.x.ware-win81-release.nondebug\build\PCbuild\pyproject.props(220,5): error : vcruntime14*.dll not found under C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\ [D:\buildarea\3.x.ware-win81-release.nondebug\build\PCbuild\pythoncore.vcxproj]

AMD64 Windows10 3.7:
https://buildbot.python.org/all/#/builders/65/builds/114

     D:\buildarea\3.7.bolen-windows10\build\PCbuild\pyproject.props(214,5): error : vcruntime14*.dll not found under C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\ [D:\buildarea\3.7.bolen-windows10\build\PCbuild\pythoncore.vcxproj]

[vstinner]

It seems like many buildbots are broken.

Maybe the "buildbot" label should be tried on PRs changing the Windows build system.

x86 Windows7 3.7:
https://buildbot.python.org/all/#/builders/53/builds/109

D:\cygwin\home\db3l\buildarea\3.7.bolen-windows7\build\PCbuild\pyproject.props(214,5): error : vcruntime14*.dll not found under D:\Program Files\Microsoft Visual Studio\2017\BuildTools\VC\ [D:\cygwin\home\db3l\buildarea\3.7.bolen-windows7\build\PCbuild\pythoncore.vcxproj]

[zooba]

Added a PR to make the failure silent, up until we're building a release package. That way it'll only bother me, and I can make sure that I have the right VS install.

[zooba]

New changeset fde44ae by Steve Dower in branch 'master':
bpo-39930: Convert error to warning for more silent failure (GH-18921)
fde44ae

[miss-islington]

New changeset 3136f6f by Miss Islington (bot) in branch '3.7':
bpo-39930: Convert error to warning for more silent failure (GH-18921)
3136f6f

[miss-islington]

New changeset 17571c5 by Miss Islington (bot) in branch '3.8':
bpo-39930: Convert error to warning for more silent failure (GH-18921)
17571c5

[zooba]

Okay, I think I've got an approach that works even on the apparently misconfigured installs on the buildbots (and some user machines, if this is the same underlying issue as bpo-38597).

I wasn't able to reproduce it though, so I have no idea why they don't have the right redist version property. Hopefully using the last-found directory under Redist continues to make sense into the future.

[miss-islington]

New changeset 894adc1 by Steve Dower in branch 'master':
bpo-39930: Fix MSBuild detection for Build Tools (GH-18938)
894adc1

[miss-islington]

New changeset 35ae5d9 by Miss Islington (bot) in branch '3.8':
bpo-39930: Fix MSBuild detection for Build Tools (GH-18938)
35ae5d9

[zooba]

New changeset c05e491 by Steve Dower in branch '3.7':
bpo-39930: Fix MSBuild detection for Build Tools (GH-18938)
c05e491