Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyModule_AddType helper function #84205

Closed
corona10 opened this issue Mar 20, 2020 · 7 comments
Closed

Add PyModule_AddType helper function #84205

corona10 opened this issue Mar 20, 2020 · 7 comments
Assignees
Labels
3.9 only security fixes topic-C-API type-feature A feature request or enhancement

Comments

@corona10
Copy link
Member

BPO 40024
Nosy @vstinner, @corona10, @shihai1991, @aeros
PRs
  • bpo-40024: Add PyModule_AddType() helper function #19088
  • bpo-40024: Update xxxxmodule to use PyModule_AddType. #19119
  • bpo-40024: Update _elementtree to use PyModule_AddType #19205
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/corona10'
    closed_at = <Date 2020-03-29.14:13:27.053>
    created_at = <Date 2020-03-20.09:39:49.300>
    labels = ['expert-C-API', 'type-feature', '3.9']
    title = 'Add PyModule_AddType helper function'
    updated_at = <Date 2020-04-01.22:33:07.698>
    user = 'https://github.com/corona10'

    bugs.python.org fields:

    activity = <Date 2020-04-01.22:33:07.698>
    actor = 'aeros'
    assignee = 'corona10'
    closed = True
    closed_date = <Date 2020-03-29.14:13:27.053>
    closer = 'vstinner'
    components = ['C API']
    creation = <Date 2020-03-20.09:39:49.300>
    creator = 'corona10'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 40024
    keywords = ['patch']
    message_count = 7.0
    messages = ['364661', '364809', '364964', '365217', '365253', '365254', '365522']
    nosy_count = 4.0
    nosy_names = ['vstinner', 'corona10', 'shihai1991', 'aeros']
    pr_nums = ['19088', '19119', '19205']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue40024'
    versions = ['Python 3.9']

    @corona10
    Copy link
    Member Author

    See: #19084 (comment)

    @corona10 corona10 added the 3.9 only security fixes label Mar 20, 2020
    @corona10 corona10 self-assigned this Mar 20, 2020
    @corona10 corona10 added topic-C-API type-feature A feature request or enhancement labels Mar 20, 2020
    @vstinner
    Copy link
    Member

    New changeset 05e4a29 by Dong-hee Na in branch 'master':
    bpo-40024: Add PyModule_AddType() helper function (GH-19088)
    05e4a29

    @vstinner
    Copy link
    Member

    New changeset 37fcbb6 by Dong-hee Na in branch 'master':
    bpo-40024: Update C extension modules to use PyModule_AddType() (GH-19119)
    37fcbb6

    @corona10 corona10 changed the title Add _PyModule_AddType private helper function Add PyModule_AddType helper function Mar 28, 2020
    @corona10
    Copy link
    Member Author

    @vstinner

    IMHO, we can close this issue after PR 19205 is merged.
    Most of use cases are replaced to PyModule_AddType.

    @vstinner
    Copy link
    Member

    New changeset 016bdd5 by Dong-hee Na in branch 'master':
    bpo-40024: Update _elementtree to use PyModule_AddType() (GH-19205)
    016bdd5

    @vstinner
    Copy link
    Member

    Thanks Dong-hee Na for fixing many reference leaks! I like the new PyModule_AddType() helper function.

    @aeros
    Copy link
    Contributor

    aeros commented Apr 1, 2020

    (disregard the above, the PR was mistakenly linked from a GitHub bug)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes topic-C-API type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants