ValueError exception on _winapi.WaitForMultipleObjects

[mingwandroid]

BPO	40263
Nosy	@pfmoore, @tjguk, @zware, @mingwandroid, @zooba, @mingwandroid, @miss-islington, @Chronial
PRs	bpo-40263: Fix off-by-one-error in _winapi_WaitForMultipleObjects_impl #19501 [3.10] bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObjects_impl (GH-19501) #27428 [3.9] bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObjects_impl (GH-19501) #27429
Files	ppe.py 0000-Fix-off-by-one-error-in-_winapi_WaitForMultipleObjec.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-07-28.20:00:26.711>
created_at = <Date 2020-04-12.18:19:42.927>
labels = ['interpreter-core', '3.7', '3.8', '3.9', 'OS-windows']
title = 'ValueError exception on _winapi.WaitForMultipleObjects'
updated_at = <Date 2021-07-29.03:16:30.318>
user = 'https://github.com/mingwandroid'

bugs.python.org fields:

activity = <Date 2021-07-29.03:16:30.318>
actor = 'jaraco'
assignee = 'none'
closed = True
closed_date = <Date 2021-07-28.20:00:26.711>
closer = 'steve.dower'
components = ['Interpreter Core', 'Windows']
creation = <Date 2020-04-12.18:19:42.927>
creator = 'Ray Donnelly'
dependencies = []
files = ['49055', '49057']
hgrepos = []
issue_num = 40263
keywords = ['patch']
message_count = 9.0
messages = ['366258', '366259', '366301', '366312', '397871', '398418', '398419', '398420', '398432']
nosy_count = 8.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'Ray.Donnelly', 'steve.dower', 'Ray Donnelly', 'miss-islington', 'Chronial']
pr_nums = ['19501', '27428', '27429']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue40263'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9']

[mingwandroid]

See attached reproducer

[mingwandroid]

See my proposed patch. I am happy to make a PR on github for this too if people agree it's the right fix.

[zooba]

(Created from bpo-26903)

Yeah, that looks like a reasonable fix :)

[mingwandroid]

#19501

[Chronial]

This is still an issue in python3.9. It just hit us while using the default config on a Threadripper 3990X that has 128 logical cores:

  with concurrent.futures.ProcessPoolExecutor() as executor:

[zooba]

New changeset 92b5dc7 by Ray Donnelly in branch 'main':
bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObjects_impl (GH-19501)
92b5dc7

[zooba]

Fixed, better late than never.

[miss-islington]

New changeset bccb7b9 by Miss Islington (bot) in branch '3.10':
bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObjects_impl (GH-19501)
bccb7b9

[zooba]

New changeset 899e37b by Miss Islington (bot) in branch '3.9':
bpo-40263: Fixes an off-by-one error in _winapi_WaitForMultipleObjects_impl (GH-19501)
899e37b