socket library support for CAN_J1939

[karlding]

BPO	40291
Nosy	@gvanrossum, @orsenthil, @miss-islington, @karlding
PRs	bpo-40291: Add support for CAN_J1939 sockets #19538 bpo-40291: Mention socket.CAN_J1939 in What's New #20248 [3.9] bpo-40291: Mention socket.CAN_J1939 in What's New (GH-20248) #20249

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-04-29.22:32:24.519>
created_at = <Date 2020-04-15.05:29:19.079>
labels = ['type-feature', 'library', '3.9']
title = 'socket library support for CAN_J1939'
updated_at = <Date 2020-05-20.02:37:24.395>
user = 'https://github.com/karlding'

bugs.python.org fields:

activity = <Date 2020-05-20.02:37:24.395>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2020-04-29.22:32:24.519>
closer = 'gvanrossum'
components = ['Library (Lib)']
creation = <Date 2020-04-15.05:29:19.079>
creator = 'karlding'
dependencies = []
files = []
hgrepos = []
issue_num = 40291
keywords = ['patch']
message_count = 7.0
messages = ['366487', '367534', '367708', '367709', '369413', '369414', '369415']
nosy_count = 4.0
nosy_names = ['gvanrossum', 'orsenthil', 'miss-islington', 'karlding']
pr_nums = ['19538', '20248', '20249']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40291'
versions = ['Python 3.9']

[karlding]

It would be nice to have support J1939 sockets.

Support for J1939 landed as part of the SAE J1939 SocketCAN patches, which are available after the Linux 5.4rc1 kernel. This is another protocol family for SocketCAN, much like the existing support for ISOTP and BCM.

Effectively, supporting this would hand off as much to the kernel as possible, which gives Python programs the ability deal with J1939 without having to implement the logic existing in the kernel in userspace.

This is provided to userspace [0] via the <linux/can/j1939.h> header.

I'd be happy to work on this and provide a PR.

[0] https://www.kernel.org/doc/html/latest/networking/j1939.html

[gvanrossum]

Looks reasonable.

[miss-islington]

New changeset 360371f by karl ding in branch 'master':
bpo-40291: Add support for CAN_J1939 sockets (GH-19538)
360371f

[gvanrossum]

Thanks, good luck using this!

[karlding]

Should this be added to the What's New for 3.9? I see a smaller change that exposes the CAN_RAW_JOIN_FILTERS constant mentioned.

I've created #20248 if this is needed.

[miss-islington]

New changeset 550f30c by karl ding in branch 'master':
bpo-40291: Mention socket.CAN_J1939 in What's New (GH-20248)
550f30c

[miss-islington]

New changeset 12fa658 by Miss Islington (bot) in branch '3.9':
bpo-40291: Mention socket.CAN_J1939 in What's New (GH-20248)
12fa658