_dirnameW is used outside HAVE_SYMLINK

[gongminmin]

BPO	40653
Nosy	@pfmoore, @tjguk, @zware, @gongminmin, @zooba, @miss-islington
PRs	bpo-40653: Move _dirnameW out of #ifdef HAVE_SYMLINK/#endif #20144 [3.8] bpo-40653: Move _dirnameW out of GH-ifdef HAVE_SYMLINK/GH-endif (GH-20144) #20185 [3.7] bpo-40653: Move _dirnameW out of GH-ifdef HAVE_SYMLINK/GH-endif (GH-20144) #20186

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-05-18.16:18:07.258>
created_at = <Date 2020-05-17.03:05:19.654>
labels = ['build', '3.8', 'OS-windows']
title = '_dirnameW is used outside HAVE_SYMLINK'
updated_at = <Date 2020-05-18.16:36:09.602>
user = 'https://github.com/gongminmin'

bugs.python.org fields:

activity = <Date 2020-05-18.16:36:09.602>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2020-05-18.16:18:07.258>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2020-05-17.03:05:19.654>
creator = 'Minmin.Gong'
dependencies = []
files = []
hgrepos = []
issue_num = 40653
keywords = ['patch']
message_count = 5.0
messages = ['369089', '369262', '369264', '369270', '369271']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'Minmin.Gong', 'steve.dower', 'miss-islington']
pr_nums = ['20144', '20185', '20186']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue40653'
versions = ['Python 3.8']

[gongminmin]

_dirnameW is defined inside #ifdef HAVE_SYMLINK/#endif, but it's used in os__getdiskusage_impl, which is outside HAVE_SYMLINK. So if HAVE_SYMLINK is not defined (e.g., on UWP), it'll have compiling issues.

[zooba]

New changeset 7f21c9a by Minmin Gong in branch 'master':
bpo-40653: Move _dirnameW out of #ifdef HAVE_SYMLINK/#endif (GH-20144)
7f21c9a

[zooba]

Thanks! Nice catch.

Closing this, but I'll keep an eye on the backports.

[miss-islington]

New changeset 6da26f8 by Miss Islington (bot) in branch '3.7':
bpo-40653: Move _dirnameW out of GH-ifdef HAVE_SYMLINK/GH-endif (GH-20144)
6da26f8

[miss-islington]

New changeset ddd5bbd by Miss Islington (bot) in branch '3.8':
bpo-40653: Move _dirnameW out of GH-ifdef HAVE_SYMLINK/GH-endif (GH-20144)
ddd5bbd