Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly drop support for SQLite version < 3.7.3 #84921

Closed
erlend-aasland opened this issue May 23, 2020 · 5 comments
Closed

Explicitly drop support for SQLite version < 3.7.3 #84921

erlend-aasland opened this issue May 23, 2020 · 5 comments
Labels
3.10 stdlib

Comments

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 23, 2020

BPO 40744
Nosy @ambv, @berkerpeksag, @pablogsal, @erlend-aasland
PRs
  • #20330
  • #20909
  • Files
  • 0001-Drop-support-for-sqlite3-3.7.3.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-09-07.21:29:10.517>
    created_at = <Date 2020-05-23.16:40:54.878>
    labels = ['library', '3.10']
    title = 'Explicitly drop support for SQLite version < 3.7.3'
    updated_at = <Date 2020-09-07.21:29:13.993>
    user = 'https://github.com/erlend-aasland'

    bugs.python.org fields:

    activity = <Date 2020-09-07.21:29:13.993>
    actor = 'pablogsal'
    assignee = 'none'
    closed = True
    closed_date = <Date 2020-09-07.21:29:10.517>
    closer = 'pablogsal'
    components = ['Library (Lib)']
    creation = <Date 2020-05-23.16:40:54.878>
    creator = 'erlendaasland'
    dependencies = []
    files = ['49187']
    hgrepos = []
    issue_num = 40744
    keywords = ['patch']
    message_count = 5.0
    messages = ['369729', '374025', '376530', '376531', '376532']
    nosy_count = 4.0
    nosy_names = ['lukasz.langa', 'berker.peksag', 'pablogsal', 'erlendaasland']
    pr_nums = ['20330', '20909']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue40744'
    versions = ['Python 3.10']

    @erlend-aasland
    Copy link
    Contributor Author

    @erlend-aasland erlend-aasland commented May 23, 2020

    Currently, we use sqlite3_create_function_v2() without wrapping it in any #ifdefs, so in practise the sqlite3 module will not build against sqlite3 pre 3.7.3. Despite this, we still wrap parts of the code in #ifdefs for versions 3.6.x and older.

    Added patch drops support for sqlite3 pre 3.7.3.

    @erlend-aasland erlend-aasland added 3.8 3.9 3.10 stdlib and removed 3.8 labels May 23, 2020
    @erlend-aasland
    Copy link
    Contributor Author

    @erlend-aasland erlend-aasland commented Jul 20, 2020

    Łukasz, pinging you, since you are the release manager of 3.9.

    Without PR 20909, 3.9 will be released without explicitly requiring SQLite 3.7.3 (setup.py looks for SQLite >= 3.7.2), compiling python 3.9 against SQLite 3.7.2 will fail at build time because of commit b9a0376, and it will also be possible to compile with SQLite 3.7.3 but run with pre SQLite 3.7.3 libraries, which could end up with a core dump.

    With PR 20909, we explicitly state, in the docs, that SQLite 3.7.3 is required, and we explicitly check the SQLite version at configure time (setup.py), compile time (#ifdef => #error), and run time (if sqlite3_libversion_number() < ...) to prevent CPython from being configured, build, or run against unsupported SQLite versions.

    I might be overestimating the severity of this issue, but I thought you would be interested this, as the release manager of 3.9 :)

    @pablogsal
    Copy link
    Member

    @pablogsal pablogsal commented Sep 7, 2020

    New changeset 207c321 by Erlend Egeberg Aasland in branch 'master':
    bpo-40744: Drop support for SQLite pre 3.7.3 (GH-20909)
    207c321

    @pablogsal
    Copy link
    Member

    @pablogsal pablogsal commented Sep 7, 2020

    Given the status of the 3.9 branch and given that this does not add anything new or fixes any specific bug, I would recommend to not backport this

    @pablogsal
    Copy link
    Member

    @pablogsal pablogsal commented Sep 7, 2020

    Feel free to re-open if i missed something :)

    @pablogsal pablogsal removed the 3.9 label Sep 7, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 stdlib
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants