Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pure Wayland to get default XDG webbrowser #84944

Closed
jtheoof mannequin opened this issue May 25, 2020 · 5 comments
Closed

Allow pure Wayland to get default XDG webbrowser #84944

jtheoof mannequin opened this issue May 25, 2020 · 5 comments
Assignees
Labels
3.7 (EOL) end of life 3.8 (EOL) end of life 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@jtheoof
Copy link
Mannequin

jtheoof mannequin commented May 25, 2020

BPO 40767
Nosy @orsenthil, @miss-islington, @jtheoof
PRs
  • bpo-40767: Allow pure Wayland to get default XDG web browser #20382
  • [3.9] bpo-40767: Allow pure Wayland to get default XDG web browser (GH-20382) #20607
  • [3.8] bpo-40767: Allow pure Wayland to get default XDG web browser (GH-20382) #20608
  • [3.7] bpo-40767: Allow pure Wayland to get default XDG web browser (GH-20382) #20609
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/orsenthil'
    closed_at = <Date 2020-06-03.13:11:06.116>
    created_at = <Date 2020-05-25.11:38:08.721>
    labels = ['type-bug', '3.8', '3.9', '3.10', '3.7', 'library']
    title = 'Allow pure Wayland to get default XDG webbrowser'
    updated_at = <Date 2020-06-03.13:11:06.114>
    user = 'https://github.com/jtheoof'

    bugs.python.org fields:

    activity = <Date 2020-06-03.13:11:06.114>
    actor = 'orsenthil'
    assignee = 'orsenthil'
    closed = True
    closed_date = <Date 2020-06-03.13:11:06.116>
    closer = 'orsenthil'
    components = ['Library (Lib)']
    creation = <Date 2020-05-25.11:38:08.721>
    creator = 'Jeremy Attali'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 40767
    keywords = ['patch']
    message_count = 5.0
    messages = ['369872', '370662', '370667', '370668', '370669']
    nosy_count = 4.0
    nosy_names = ['orsenthil', 'python-dev', 'miss-islington', 'Jeremy Attali']
    pr_nums = ['20382', '20607', '20608', '20609']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue40767'
    versions = ['Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10']

    @jtheoof
    Copy link
    Mannequin Author

    jtheoof mannequin commented May 25, 2020

    In a pure Wayland environment (without xwayland), the DISPLAY environment variable is not present. Therefore the call to xdg-settings get default-browser is not made. So the webbrowser behaviour is different between X11 and Wayland environment. I'm working on a fix, should submit a GitHub PR soon.

    ❯ export | grep DISPLAY
    WAYLAND_DISPLAY=wayland-0
    ❯ python -c "import webbrowser; print(webbrowser.get())"
    <webbrowser.GenericBrowser object at 0x7f6f1b755160>
    

    @jtheoof jtheoof mannequin added 3.10 only security fixes 3.7 (EOL) end of life 3.8 (EOL) end of life 3.9 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels May 25, 2020
    @miss-islington
    Copy link
    Contributor

    New changeset c822efe by Jeremy Attali in branch 'master':
    bpo-40767: Allow pure Wayland to get default XDG web browser (GH-20382)
    c822efe

    @miss-islington
    Copy link
    Contributor

    New changeset 911c35d by Miss Islington (bot) in branch '3.7':
    bpo-40767: Allow pure Wayland to get default XDG web browser (GH-20382)
    911c35d

    @miss-islington
    Copy link
    Contributor

    New changeset 5b8787e by Miss Islington (bot) in branch '3.8':
    bpo-40767: Allow pure Wayland to get default XDG web browser (GH-20382)
    5b8787e

    @miss-islington
    Copy link
    Contributor

    New changeset 74a1fce by Miss Islington (bot) in branch '3.9':
    bpo-40767: Allow pure Wayland to get default XDG web browser (GH-20382)
    74a1fce

    @orsenthil orsenthil self-assigned this Jun 3, 2020
    @orsenthil orsenthil self-assigned this Jun 3, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.7 (EOL) end of life 3.8 (EOL) end of life 3.9 only security fixes 3.10 only security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants