pdb reads source files using the locale encoding

[serhiy-storchaka]

BPO	41058
Nosy	@gpshead, @serhiy-storchaka, @miss-islington
PRs	bpo-41058: Use source file encoding in pdb.find_function(). #21010 [3.8] bpo-41058: Use source file encoding in pdb.find_function(). (GH-21010) #21026 [3.7] bpo-41058: Use source file encoding in pdb.find_function(). (GH-21010) #21027 [3.9] bpo-41058: Use source file encoding in pdb.find_function(). (GH-21010) #21034

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-06-21.19:57:17.993>
created_at = <Date 2020-06-20.17:54:13.183>
labels = ['3.8', 'type-bug', 'library', '3.9', '3.10']
title = 'pdb reads source files using the locale encoding'
updated_at = <Date 2020-06-28.13:02:39.816>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2020-06-28.13:02:39.816>
actor = 'ned.deily'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-21.19:57:17.993>
closer = 'gregory.p.smith'
components = ['Library (Lib)']
creation = <Date 2020-06-20.17:54:13.183>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 41058
keywords = ['patch']
message_count = 5.0
messages = ['371950', '371984', '372015', '372016', '372017']
nosy_count = 3.0
nosy_names = ['gregory.p.smith', 'serhiy.storchaka', 'miss-islington']
pr_nums = ['21010', '21026', '21027', '21034']
priority = 'normal'
resolution = 'fixed'
stage = 'commit review'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41058'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

[serhiy-storchaka]

find_function() in pdb uses the locale encoding for reading source files. It should use the encoding specified by the coding cookie or UTF-8 if it is not specified.

[serhiy-storchaka]

New changeset 19fcffa by Serhiy Storchaka in branch 'master':
bpo-41058: Use source file encoding in pdb.find_function(). (GH-21010)
19fcffa

[miss-islington]

New changeset 1419559 by Miss Islington (bot) in branch '3.8':
bpo-41058: Use source file encoding in pdb.find_function(). (GH-21010)
1419559

[miss-islington]

New changeset 26f6126 by Miss Islington (bot) in branch '3.9':
bpo-41058: Use source file encoding in pdb.find_function(). (GH-21010)
26f6126

[gpshead]

The 3.7 PR is up to the release manager to decide on, it probably isn't worth merging there as this i not security related. thanks for the fix Serhiy!