Incorrect reference counting in _ssl.c's _servername_callback()

[ZackerySpytz]

BPO	41252
Nosy	@tiran, @ZackerySpytz, @miss-islington
PRs	bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() #21407 [3.9] bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() (GH-21407) #21410 [3.8] bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() (GH-21407) #21411

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tiran'
closed_at = <Date 2020-07-09.10:27:55.374>
created_at = <Date 2020-07-09.03:53:04.265>
labels = ['expert-SSL', 'type-bug', '3.8', '3.9', '3.10', 'extension-modules']
title = "Incorrect reference counting in _ssl.c's _servername_callback()"
updated_at = <Date 2020-07-09.10:27:55.373>
user = 'https://github.com/ZackerySpytz'

bugs.python.org fields:

activity = <Date 2020-07-09.10:27:55.373>
actor = 'christian.heimes'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2020-07-09.10:27:55.374>
closer = 'christian.heimes'
components = ['Extension Modules', 'SSL']
creation = <Date 2020-07-09.03:53:04.265>
creator = 'ZackerySpytz'
dependencies = []
files = []
hgrepos = []
issue_num = 41252
keywords = ['patch']
message_count = 5.0
messages = ['373371', '373389', '373391', '373392', '373393']
nosy_count = 3.0
nosy_names = ['christian.heimes', 'ZackerySpytz', 'miss-islington']
pr_nums = ['21407', '21410', '21411']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41252'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

[ZackerySpytz]

In _servername_callback(), servername_bytes will be used after being
decrefed if PyUnicode_FromEncodedObject() fails.

[miss-islington]

New changeset ee96f32 by Zackery Spytz in branch 'master':
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() (GH-21407)
ee96f32

[miss-islington]

New changeset 54babbe by Miss Islington (bot) in branch '3.8':
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() (GH-21407)
54babbe

[miss-islington]

New changeset 90584c0 by Miss Islington (bot) in branch '3.9':
bpo-41252: Fix incorrect refcounting in _ssl.c's _servername_callback() (GH-21407)
90584c0

[tiran]

Thanks!