Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signing description for Windows release builds #85664

Closed
zooba opened this issue Aug 5, 2020 · 4 comments
Closed

Fix signing description for Windows release builds #85664

zooba opened this issue Aug 5, 2020 · 4 comments
Assignees
Labels
3.8 only security fixes 3.9 only security fixes 3.10 only security fixes OS-windows type-bug An unexpected behavior, bug, or error

Comments

@zooba
Copy link
Member

zooba commented Aug 5, 2020

BPO 41492
Nosy @pfmoore, @tjguk, @zware, @zooba, @miss-islington
PRs
  • bpo-41492: Fixes the description appearing in UAC prompts #21754
  • [3.9] bpo-41492: Fixes the description appearing in UAC prompts on Windows (GH-21754) #21755
  • [3.8] bpo-41492: Fixes the description appearing in UAC prompts on Windows (GH-21754) #21756
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
    closed_at = <Date 2020-09-24.20:39:03.682>
    created_at = <Date 2020-08-05.23:35:01.575>
    labels = ['3.10', 'type-bug', '3.8', '3.9', 'OS-windows']
    title = 'Fix signing description for Windows release builds'
    updated_at = <Date 2020-09-24.20:39:03.682>
    user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2020-09-24.20:39:03.682>
    actor = 'steve.dower'
    assignee = 'steve.dower'
    closed = True
    closed_date = <Date 2020-09-24.20:39:03.682>
    closer = 'steve.dower'
    components = ['Windows']
    creation = <Date 2020-08-05.23:35:01.575>
    creator = 'steve.dower'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 41492
    keywords = ['patch']
    message_count = 4.0
    messages = ['374910', '374945', '374947', '374948']
    nosy_count = 5.0
    nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'miss-islington']
    pr_nums = ['21754', '21755', '21756']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue41492'
    versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

    @zooba
    Copy link
    Member Author

    zooba commented Aug 5, 2020

    At some point, Windows started displaying an authenticated certificate property as the display name in UAC prompts, rather than the file properties.

    Currently our SigningDescription is set to the build identifier, which is not a nice display name. We should change it to be "Python 3.x.y" (which will involve updating the build YAML files to extract the version number).

    @zooba zooba added 3.8 only security fixes 3.9 only security fixes 3.10 only security fixes labels Aug 5, 2020
    @zooba zooba self-assigned this Aug 5, 2020
    @zooba zooba added OS-windows 3.8 only security fixes type-bug An unexpected behavior, bug, or error 3.9 only security fixes 3.10 only security fixes labels Aug 5, 2020
    @zooba zooba self-assigned this Aug 5, 2020
    @zooba zooba added OS-windows type-bug An unexpected behavior, bug, or error labels Aug 5, 2020
    @zooba
    Copy link
    Member Author

    zooba commented Aug 6, 2020

    New changeset 777b611 by Steve Dower in branch 'master':
    bpo-41492: Fixes the description appearing in UAC prompts on Windows (GH-21754)
    777b611

    @miss-islington
    Copy link
    Contributor

    New changeset 713ba03 by Miss Islington (bot) in branch '3.8':
    bpo-41492: Fixes the description appearing in UAC prompts on Windows (GH-21754)
    713ba03

    @miss-islington
    Copy link
    Contributor

    New changeset 1437bb0 by Miss Islington (bot) in branch '3.9':
    bpo-41492: Fixes the description appearing in UAC prompts on Windows (GH-21754)
    1437bb0

    @zooba zooba closed this as completed Sep 24, 2020
    @zooba zooba closed this as completed Sep 24, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.8 only security fixes 3.9 only security fixes 3.10 only security fixes OS-windows type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants