Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show deprecation warnings for tkinter.tix #85896

Closed
wyz23x2 mannequin opened this issue Sep 6, 2020 · 17 comments
Closed

Show deprecation warnings for tkinter.tix #85896

wyz23x2 mannequin opened this issue Sep 6, 2020 · 17 comments
Labels
3.10 only security fixes 3.11 bug and security fixes topic-tkinter type-bug An unexpected behavior, bug, or error

Comments

@wyz23x2
Copy link
Mannequin

wyz23x2 mannequin commented Sep 6, 2020

BPO 41730
Nosy @zware, @serhiy-storchaka, @pablogsal, @miss-islington, @tirkarthi, @wyz23x2, @E-Paine
PRs
  • bpo-41730: Show deprecation warnings for tkinter.tix #22186
  • [3.10] bpo-41730: Show deprecation warnings for tkinter.tix (GH-22186) #25971
  • Revert test for Tix deprecation warning #26005
  • [3.10] Revert test for Tix deprecation warning (GH-26005) #26006
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-05-09.07:04:01.459>
    created_at = <Date 2020-09-06.03:54:50.978>
    labels = ['type-bug', 'expert-tkinter', '3.10', '3.11']
    title = 'Show deprecation warnings for tkinter.tix'
    updated_at = <Date 2021-05-09.07:19:50.171>
    user = 'https://github.com/wyz23x2'

    bugs.python.org fields:

    activity = <Date 2021-05-09.07:19:50.171>
    actor = 'miss-islington'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-05-09.07:04:01.459>
    closer = 'zach.ware'
    components = ['Tkinter']
    creation = <Date 2020-09-06.03:54:50.978>
    creator = 'wyz23x2'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 41730
    keywords = ['patch']
    message_count = 17.0
    messages = ['376455', '376459', '376563', '376675', '376677', '376679', '376680', '376683', '376707', '376826', '388838', '393100', '393191', '393192', '393296', '393302', '393305']
    nosy_count = 8.0
    nosy_names = ['gpolo', 'zach.ware', 'serhiy.storchaka', 'pablogsal', 'miss-islington', 'xtreak', 'wyz23x2', 'epaine']
    pr_nums = ['22186', '25971', '26005', '26006']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue41730'
    versions = ['Python 3.10', 'Python 3.11']

    @wyz23x2
    Copy link
    Mannequin Author

    wyz23x2 mannequin commented Sep 6, 2020

    The tkinter.tix module was deprecated since Python 3.6, but nether DeprecationWarning nor PendingDeprecationWarning is warned. It should show a message and removal might be scheduled for 3.11/3.12.

    @wyz23x2 wyz23x2 mannequin added 3.9 only security fixes 3.10 only security fixes topic-tkinter type-bug An unexpected behavior, bug, or error labels Sep 6, 2020
    @tirkarthi
    Copy link
    Member

    The removal was suggested before but not merged in https://bugs.python.org/issue31371

    @E-Paine
    Copy link
    Mannequin

    E-Paine mannequin commented Sep 8, 2020

    +1

    I think this would be very helpful as the only places I can find its deprecation are a small note at the top of the Tix Python docs [https://github.com/python/cpython/commit/bd63353] and a news entry a long way down the 3.6 release notes https://docs.python.org/3/whatsnew/3.6.html#id7 [https://github.com/python/cpython/commit/ba41c81].

    While I agree with @zachary's comment on bpo-29125 that the injection bug probably would be a reasonable excuse to remove Tix, I believe we should first "properly" deprecate it (I can imagine a few users getting caught out if we remove it without raising a DeprecationWarning in previous versions).

    IMO, bpo-31371 should be reopened once this has been merged to facilitate removal in a future version and allow discussion for which version removal should occur in. I also think that we should back-port this to 3.8/9 to give users more notice than they might otherwise get.

    @wyz23x2, are you alright to write a patch for this? (I assume no-one has any objections given that Tix is already deprecated)

    @E-Paine E-Paine mannequin added 3.8 only security fixes labels Sep 8, 2020
    @wyz23x2
    Copy link
    Mannequin Author

    wyz23x2 mannequin commented Sep 10, 2020

    OK. What should the message be? "tkinter.tix is deprecated (and will be removed in Python 3.x), use tkinter.ttk instead"?

    @E-Paine
    Copy link
    Mannequin

    E-Paine mannequin commented Sep 10, 2020

    As I believe planning for removal (including the version this should occur in) is better suited to bpo-31371, I think it would be best to remain non-committal about the version. I would personally prefer something a little more vague (such as below), though as I keep saying, this is just my opinion.

    DeprecationWarning: the tkinter.tix module is deprecated in favour of tkinter.ttk and is set to be removed in the near-future

    It *may* also be nice to clarify in the docs why Tix is deprecated (i.e. unmaintained), though I will leave this (like the deprecation message) at your discretion.

    @wyz23x2
    Copy link
    Mannequin Author

    wyz23x2 mannequin commented Sep 10, 2020

    @epaine The doc (https://docs.python.org/3/library/tkinter.tix.html) states "This Tk extension is unmaintained and should not be used in new code.".

    @wyz23x2
    Copy link
    Mannequin Author

    wyz23x2 mannequin commented Sep 10, 2020

    All tests have passed. Now it's time to merge!

    @wyz23x2
    Copy link
    Mannequin Author

    wyz23x2 mannequin commented Sep 10, 2020

    Can any core reviewer review the PR?

    @wyz23x2
    Copy link
    Mannequin Author

    wyz23x2 mannequin commented Sep 11, 2020

    Ping? We will miss 3.8.6/3.9.0rc2 if it's too late!

    @wyz23x2
    Copy link
    Mannequin Author

    wyz23x2 mannequin commented Sep 13, 2020

    Ping...

    @wyz23x2
    Copy link
    Mannequin Author

    wyz23x2 mannequin commented Mar 16, 2021

    Um, is this going on?

    @wyz23x2
    Copy link
    Mannequin Author

    wyz23x2 mannequin commented May 6, 2021

    When this issue was submitted on September 5, 2020, Python 3.9 was still in beta/rc stages. Now 242 days have passed and the developing of 3.11 has started. :)

    @wyz23x2 wyz23x2 mannequin added 3.11 bug and security fixes and removed 3.8 only security fixes labels May 6, 2021
    @wyz23x2
    Copy link
    Mannequin Author

    wyz23x2 mannequin commented May 7, 2021

    Merged!

    @wyz23x2 wyz23x2 mannequin closed this as completed May 7, 2021
    @wyz23x2 wyz23x2 mannequin closed this as completed May 7, 2021
    @wyz23x2 wyz23x2 mannequin removed the 3.9 only security fixes label May 7, 2021
    @wyz23x2 wyz23x2 mannequin removed the 3.9 only security fixes label May 7, 2021
    @miss-islington
    Copy link
    Contributor

    New changeset ec6a1ea by Miss Islington (bot) in branch '3.10':
    bpo-41730: Show deprecation warnings for tkinter.tix (GH-22186)
    ec6a1ea

    @pablogsal
    Copy link
    Member

    Unfortunately this commit has introduced some reference leaks, see:

    https://buildbot.python.org/all/#/builders/684/builds/5

    Could someone take a look?

    @pablogsal pablogsal reopened this May 9, 2021
    @pablogsal pablogsal reopened this May 9, 2021
    @zware
    Copy link
    Member

    zware commented May 9, 2021

    Fixed in #70193 and #70194, which just revert the test.

    @zware zware closed this as completed May 9, 2021
    @zware zware closed this as completed May 9, 2021
    @miss-islington
    Copy link
    Contributor

    New changeset c3eb3c1 by Miss Islington (bot) in branch '3.10':
    Revert test for Tix deprecation warning (GH-26005)
    c3eb3c1

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 only security fixes 3.11 bug and security fixes topic-tkinter type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants