NuGet python.props only works in python nuget, not other variants

[vslavik]

BPO	41744
Nosy	@pfmoore, @tjguk, @vslavik, @methane, @zware, @zooba, @miss-islington
PRs	bpo-41744: Package NuGet python.props with correct name to be used #22154 [3.9] bpo-41744: Package python.props with correct name in NuGet package (GH-22154) #22245 [3.8] bpo-41744: Package python.props with correct name in NuGet package (GH-22154) #22246

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2020-09-14.19:32:06.581>
created_at = <Date 2020-09-08.15:33:50.205>
labels = ['3.10', 'type-bug', '3.8', '3.9', 'OS-windows']
title = 'NuGet python.props only works in python nuget, not other variants'
updated_at = <Date 2020-10-21.05:15:26.175>
user = 'https://github.com/vslavik'

bugs.python.org fields:

activity = <Date 2020-10-21.05:15:26.175>
actor = 'methane'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2020-09-14.19:32:06.581>
closer = 'steve.dower'
components = ['Windows']
creation = <Date 2020-09-08.15:33:50.205>
creator = 'vslavik'
dependencies = []
files = []
hgrepos = []
issue_num = 41744
keywords = ['patch']
message_count = 9.0
messages = ['376577', '376580', '376678', '376696', '376798', '376893', '376895', '376899', '379190']
nosy_count = 7.0
nosy_names = ['paul.moore', 'tim.golden', 'vslavik', 'methane', 'zach.ware', 'steve.dower', 'miss-islington']
pr_nums = ['22154', '22245', '22246']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41744'
versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

[vslavik]

NuGet automatically includes .props file from the build directory in the target using the package, but only if the file has the correct name: it must be $(id).props. This means that Python's support for this only works correctly in the python nuget packages, but not in pythonx86 and others, because the file is copied as python.props (instead of pythonx86.props etc) there too.

[zooba]

Thanks for the contribution! I think I only ever tested this with the 64-bit package... :)

Could you make it so that we include the file under both names? Just for anyone (like me) who has hard-coded the python.props name and parametrised the directory name.

(If you want to go for bonus points, having the extra file just <Import> the other would be a nice touch, but not so important.)

[vslavik]

Thank you, I didn't consider that situation. I forced-pushed an update to the PR now.

I opted for duplicate file rather than including, because I think it imposes the least maintenance burden on keeping compatibility: the other alternative would mean

• one more file
• either a more complicated logic or the primary file including the compat one (so "normal" path slightly more convoluted)
• tiny, but not 100% trivial difference between python nuget and the other ones.

[zooba]

Thanks! Just need a NEWS file (click Details next to the failed check for the helper app). Something like "Fixes automatic import of props file when using the Nuget package" would be good.

(Also posted on the PR)

[vslavik]

Sorry for the omission (fixed now), and thanks for your patience!

[zooba]

New changeset 7c11a9a by Václav Slavík in branch 'master':
bpo-41744: Package python.props with correct name in NuGet package (GH-22154)
7c11a9a

[zooba]

Thanks!

[miss-islington]

New changeset b007a9b by Miss Islington (bot) in branch '3.8':
bpo-41744: Package python.props with correct name in NuGet package (GH-22154)
b007a9b

[methane]

New changeset d0bfce9 by Miss Skeleton (bot) in branch '3.9':
bpo-41744: Package python.props with correct name in NuGet package (GH-22154)
d0bfce9