-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuGet python.props only works in python nuget, not other variants #85910
Comments
NuGet automatically includes .props file from the build directory in the target using the package, but only if the file has the correct name: it must be $(id).props. This means that Python's support for this only works correctly in the python nuget packages, but not in pythonx86 and others, because the file is copied as python.props (instead of pythonx86.props etc) there too. |
Thanks for the contribution! I think I only ever tested this with the 64-bit package... :) Could you make it so that we include the file under both names? Just for anyone (like me) who has hard-coded the python.props name and parametrised the directory name. (If you want to go for bonus points, having the extra file just <Import> the other would be a nice touch, but not so important.) |
Thank you, I didn't consider that situation. I forced-pushed an update to the PR now. I opted for duplicate file rather than including, because I think it imposes the least maintenance burden on keeping compatibility: the other alternative would mean
|
Thanks! Just need a NEWS file (click Details next to the failed check for the helper app). Something like "Fixes automatic import of props file when using the Nuget package" would be good. (Also posted on the PR) |
Sorry for the omission (fixed now), and thanks for your patience! |
Thanks! |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: