Promote PyObject_GenericGetDict to the stable API

[alex]

BPO	41845
Nosy	@benjaminp, @alex, @markshannon, @serhiy-storchaka, @zooba, @ZackerySpytz
PRs	bpo-41845: Move PyObject_GenericGetDict() back into the limited API #22646

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-10-19.22:49:30.685>
created_at = <Date 2020-09-23.14:31:49.119>
labels = ['expert-C-API', '3.10']
title = 'Promote PyObject_GenericGetDict to the stable API'
updated_at = <Date 2020-10-19.22:49:30.685>
user = 'https://github.com/alex'

bugs.python.org fields:

activity = <Date 2020-10-19.22:49:30.685>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2020-10-19.22:49:30.685>
closer = 'steve.dower'
components = ['C API']
creation = <Date 2020-09-23.14:31:49.119>
creator = 'alex'
dependencies = []
files = []
hgrepos = []
issue_num = 41845
keywords = ['patch']
message_count = 8.0
messages = ['377388', '377404', '377406', '377410', '378426', '379024', '379051', '379053']
nosy_count = 6.0
nosy_names = ['benjamin.peterson', 'alex', 'Mark.Shannon', 'serhiy.storchaka', 'steve.dower', 'ZackerySpytz']
pr_nums = ['22646']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue41845'
versions = ['Python 3.10']

[alex]

Currently PyObject_GenericSetDict is part of the stable API, but PyObject_GenericGetDict is not. I noticed this while working on PyO3/pyo3#1207

Because of the symmetry here, it seems appropriate to promote Get.

[serhiy-storchaka]

It was moved out from the limited API in bpo-13903 (7d95e40). I think it was error.

[markshannon]

It wasn't removed in 7d95e40,
just moved from object.h to dictobject.h
It was still part of the API at that point, I think.

[serhiy-storchaka]

It was moved into the "#ifndef Py_LIMITED_API" block and therefore was effectively excluded from the limited API.

We should fix this error in all maintained versions.

[ZackerySpytz]

I have created PR 22646 to fix this issue. Please consider taking a look.

[zooba]

Unfortunately, fixing this won't make the builds work in previous versions, so it can't be backported.

We also need to update the version check in the PR - I left a comment for it.

[zooba]

New changeset 1438c2a by Zackery Spytz in branch 'master':
bpo-41845: Move PyObject_GenericGetDict() back into the limited API (GH22646)
1438c2a

[zooba]

Thanks!