Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vectorcall for float() #86039

Closed
sweeneyde opened this issue Sep 28, 2020 · 3 comments
Closed

Add vectorcall for float() #86039

sweeneyde opened this issue Sep 28, 2020 · 3 comments
Labels
3.10 interpreter-core performance

Comments

@sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Sep 28, 2020

BPO 41873
Nosy @vstinner, @corona10, @sweeneyde
PRs
  • #22432
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-09-29.00:58:12.992>
    created_at = <Date 2020-09-28.08:55:08.091>
    labels = ['interpreter-core', '3.10', 'performance']
    title = 'Add vectorcall for float()'
    updated_at = <Date 2021-04-06.14:49:25.534>
    user = 'https://github.com/sweeneyde'

    bugs.python.org fields:

    activity = <Date 2021-04-06.14:49:25.534>
    actor = 'corona10'
    assignee = 'none'
    closed = True
    closed_date = <Date 2020-09-29.00:58:12.992>
    closer = 'corona10'
    components = ['Interpreter Core']
    creation = <Date 2020-09-28.08:55:08.091>
    creator = 'Dennis Sweeney'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 41873
    keywords = ['patch']
    message_count = 3.0
    messages = ['377590', '377647', '377648']
    nosy_count = 3.0
    nosy_names = ['vstinner', 'corona10', 'Dennis Sweeney']
    pr_nums = ['22432']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'performance'
    url = 'https://bugs.python.org/issue41873'
    versions = ['Python 3.10']

    @sweeneyde
    Copy link
    Member Author

    @sweeneyde sweeneyde commented Sep 28, 2020

    I got these benchmarks:

    .\python.bat -m pyperf timeit "float(0)"

    Before: Mean +- std dev: 79.0 ns +- 1.0 ns
    After: Mean +- std dev: 51.5 ns +- 1.6 ns

    @sweeneyde sweeneyde added 3.10 interpreter-core performance labels Sep 28, 2020
    @corona10
    Copy link
    Member

    @corona10 corona10 commented Sep 29, 2020

    New changeset e8acc35 by Dennis Sweeney in branch 'master':
    bpo-41873: Add vectorcall for float() (GH-22432)
    e8acc35

    @corona10
    Copy link
    Member

    @corona10 corona10 commented Sep 29, 2020

    Now float() is faster!
    Thank you for your contribution, Dennis :)
    And thank you Victor as co-reviewer!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 interpreter-core performance
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants