Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zipimport] Update zipimport to use specs #86297

Closed
brettcannon opened this issue Oct 23, 2020 · 2 comments
Closed

[zipimport] Update zipimport to use specs #86297

brettcannon opened this issue Oct 23, 2020 · 2 comments
Assignees
Labels
3.10 stdlib type-bug

Comments

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Oct 23, 2020

BPO 42131
Nosy @Yhg1s, @brettcannon
PRs
  • #23187
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/brettcannon'
    closed_at = <Date 2020-11-16.23:01:09.824>
    created_at = <Date 2020-10-23.22:05:33.523>
    labels = ['type-bug', 'library', '3.10']
    title = '[zipimport] Update zipimport to use specs'
    updated_at = <Date 2020-11-16.23:01:09.823>
    user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2020-11-16.23:01:09.823>
    actor = 'brett.cannon'
    assignee = 'brett.cannon'
    closed = True
    closed_date = <Date 2020-11-16.23:01:09.824>
    closer = 'brett.cannon'
    components = ['Library (Lib)']
    creation = <Date 2020-10-23.22:05:33.523>
    creator = 'brett.cannon'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 42131
    keywords = ['patch']
    message_count = 2.0
    messages = ['379481', '380940']
    nosy_count = 2.0
    nosy_names = ['twouters', 'brett.cannon']
    pr_nums = ['23187']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue42131'
    versions = ['Python 3.10']

    @brettcannon
    Copy link
    Member Author

    @brettcannon brettcannon commented Oct 23, 2020

    zipimport only supports old PEP-302 APIs and not PEP-451 module specs (i.e. it uses load_module() instead of create_module()/exec_module(), find_mdoule() instead of find_spec()).

    Uses of both load_module() and find_module() are documented as deprecated for the import system and are slated to eventually go away.

    @brettcannon brettcannon added 3.10 stdlib type-bug labels Oct 23, 2020
    @brettcannon brettcannon reopened this Nov 7, 2020
    @brettcannon brettcannon self-assigned this Nov 7, 2020
    @brettcannon brettcannon reopened this Nov 7, 2020
    @brettcannon brettcannon self-assigned this Nov 7, 2020
    @brettcannon
    Copy link
    Member Author

    @brettcannon brettcannon commented Nov 13, 2020

    New changeset d2e94bb by Brett Cannon in branch 'master':
    bpo-42131: Add PEP-451-related methods to zipimport (GH-23187)
    d2e94bb

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 stdlib type-bug
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant