Raise ImportWarning when falling back to find_module()

[brettcannon]

BPO	42134
Nosy	@brettcannon, @vstinner, @hroncok
PRs	bpo-42134: Raise ImportWarning when calling find_module() #25044

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/brettcannon'
closed_at = <Date 2021-03-30.19:08:43.309>
created_at = <Date 2020-10-23.23:10:10.032>
labels = ['interpreter-core', '3.10']
title = 'Raise ImportWarning when falling back to find_module()'
updated_at = <Date 2021-04-08.21:31:25.417>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2021-04-08.21:31:25.417>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2021-03-30.19:08:43.309>
closer = 'brett.cannon'
components = ['Interpreter Core']
creation = <Date 2020-10-23.23:10:10.032>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 42134
keywords = ['patch']
message_count = 5.0
messages = ['379492', '389833', '390511', '390513', '390554']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'vstinner', 'hroncok']
pr_nums = ['25044']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue42134'
versions = ['Python 3.10']

[brettcannon]

find_spec() has superseded find_module() since Python 3.4.

[brettcannon]

New changeset a7ff6df by Brett Cannon in branch 'master':
bpo-42134: Raise ImportWarning when calling find_module() in the import system (GH-25044)
a7ff6df

[hroncok]

Brett, would you accept a PR that changes the changelog entry to contain the ".find_spec() not found; falling back to find_module()" message, for better search-ability? I needed to use grep + git blame to be able to find out what's going on.

Also, could you please explain how to migrate to find_spec() in https://docs.python.org/3.10/whatsnew/3.10.html#porting-to-python-3-10 ? I'd do that, but I don't know yet what is the proper way.

[vstinner]

See also bpo-43540 "importlib: Document how to replace load_module() in What's New in Python 3.10".

[brettcannon]

would you accept a PR that changes the changelog entry to contain the ".find_spec() not found; falling back to find_module()" message, for better search-ability?

Sure!

Also, could you please explain how to migrate to find_spec() in https://docs.python.org/3.10/whatsnew/3.10.html#porting-to-python-3-10 ? I'd do that, but I don't know yet what is the proper way.

The problem is it will possibly vary from class to class. You can probably get pretty far with https://docs.python.org/3/library/importlib.html#importlib.util.spec_from_file_location or https://docs.python.org/3/library/importlib.html#importlib.util.spec_from_loader depending.