Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webbrowser.MacOSX is unused, untested and undocumented #86421

Closed
ronaldoussoren opened this issue Nov 3, 2020 · 8 comments
Closed

webbrowser.MacOSX is unused, untested and undocumented #86421

ronaldoussoren opened this issue Nov 3, 2020 · 8 comments
Labels
3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes OS-mac stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@ronaldoussoren
Copy link
Contributor

BPO 42255
Nosy @ronaldoussoren, @ned-deily, @ambv, @corona10
PRs
  • bpo-42255: Deprecate webbrowser.MacOSX from Python 3.11 #27837
  • [3.10] bpo-42255: Update webbrowser doc #28144
  • [3.9] bpo-42255: Update webbrowser doc #28145
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-09-03.17:23:03.825>
    created_at = <Date 2020-11-03.19:15:01.672>
    labels = ['OS-mac', '3.9', '3.10', '3.11', 'type-feature', 'library']
    title = 'webbrowser.MacOSX is unused, untested and undocumented'
    updated_at = <Date 2021-09-03.17:23:08.907>
    user = 'https://github.com/ronaldoussoren'

    bugs.python.org fields:

    activity = <Date 2021-09-03.17:23:08.907>
    actor = 'lukasz.langa'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-09-03.17:23:03.825>
    closer = 'lukasz.langa'
    components = ['Library (Lib)', 'macOS']
    creation = <Date 2020-11-03.19:15:01.672>
    creator = 'ronaldoussoren'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 42255
    keywords = ['patch']
    message_count = 7.0
    messages = ['380293', '399766', '400910', '401001', '401008', '401009', '401010']
    nosy_count = 4.0
    nosy_names = ['ronaldoussoren', 'ned.deily', 'lukasz.langa', 'corona10']
    pr_nums = ['27837', '28144', '28145']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue42255'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @ronaldoussoren
    Copy link
    Contributor Author

    class webbrower.MacOSX is untested and undocumented. It is also not used by webbrowser itself (webbrowser.MacOSXOSAScript is used to launch browsers).

    It's probably safe to just remove the class, otherwise deprecate in 3.10 for removal in 3.11.

    @ronaldoussoren ronaldoussoren added 3.10 only security fixes stdlib Python modules in the Lib dir OS-mac type-feature A feature request or enhancement labels Nov 3, 2020
    @corona10 corona10 added 3.11 bug and security fixes and removed 3.10 only security fixes labels Aug 17, 2021
    @corona10
    Copy link
    Member

    Let's deprecate it from 3.11 and remove it at 3.12 :)

    @ambv
    Copy link
    Contributor

    ambv commented Sep 2, 2021

    Dong-hee Na, you can't remove it in 3.12 per PEP-387:

    Unless it is going through the deprecation process below, the behavior of an API must not change in an incompatible fashion between any two consecutive releases. Python's yearly release process (PEP-602) means that the deprecation period must last at least two years.

    and:

    Wait for the warning to appear in at least two minor Python versions of the same major version.

    @ambv
    Copy link
    Contributor

    ambv commented Sep 3, 2021

    New changeset bc1c49f by Dong-hee Na in branch 'main':
    bpo-42255: Deprecate webbrowser.MacOSX from Python 3.11 (GH-27837)
    bc1c49f

    @ambv
    Copy link
    Contributor

    ambv commented Sep 3, 2021

    New changeset ce83e42 by Dong-hee Na in branch '3.9':
    bpo-42255: Update webbrowser doc for macOS (GH-28145)
    ce83e42

    @ambv
    Copy link
    Contributor

    ambv commented Sep 3, 2021

    New changeset 2a8956c by Dong-hee Na in branch '3.10':
    bpo-42255: Update webbrowser doc for macOS (GH-28144)
    2a8956c

    @ambv
    Copy link
    Contributor

    ambv commented Sep 3, 2021

    Thanks for the patches, Dong-hee Na! ✨ 🍰 ✨

    @ambv ambv closed this as completed Sep 3, 2021
    @ambv ambv closed this as completed Sep 3, 2021
    @ambv ambv added 3.9 only security fixes 3.10 only security fixes labels Sep 3, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @hugovk
    Copy link
    Member

    hugovk commented May 23, 2023

    Please see PR #104816 to remove webbrowser.MacOSX.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes OS-mac stdlib Python modules in the Lib dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants