Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PCbuild/build.bat build x64 by default #86502

Closed
zooba opened this issue Nov 12, 2020 · 8 comments
Closed

Make PCbuild/build.bat build x64 by default #86502

zooba opened this issue Nov 12, 2020 · 8 comments
Assignees
Labels
3.9 only security fixes 3.10 only security fixes build The build process and cross-build OS-windows

Comments

@zooba
Copy link
Member

zooba commented Nov 12, 2020

BPO 42336
Nosy @tim-one, @pfmoore, @tjguk, @ned-deily, @zware, @zooba, @miss-islington
PRs
  • bpo-42336: Improve PCbuild batch files #23275
  • [3.8] bpo-42336: Improve PCbuild batch files (GH-23275) #23325
  • [3.9] bpo-42336: Improve PCbuild batch files (GH-23275) #23372
  • [3.7] bpo-42336: Improve PCbuild batch files (GH-23325) #23373
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
    closed_at = <Date 2020-11-21.01:10:15.149>
    created_at = <Date 2020-11-12.22:50:50.338>
    labels = ['3.10', 'build', '3.9', 'OS-windows']
    title = 'Make PCbuild/build.bat build x64 by default'
    updated_at = <Date 2020-11-21.01:10:15.147>
    user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2020-11-21.01:10:15.147>
    actor = 'steve.dower'
    assignee = 'steve.dower'
    closed = True
    closed_date = <Date 2020-11-21.01:10:15.149>
    closer = 'steve.dower'
    components = ['Build', 'Windows']
    creation = <Date 2020-11-12.22:50:50.338>
    creator = 'steve.dower'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 42336
    keywords = ['patch']
    message_count = 8.0
    messages = ['380858', '380860', '380942', '381360', '381361', '381363', '381367', '381513']
    nosy_count = 7.0
    nosy_names = ['tim.peters', 'paul.moore', 'tim.golden', 'ned.deily', 'zach.ware', 'steve.dower', 'miss-islington']
    pr_nums = ['23275', '23325', '23372', '23373']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue42336'
    versions = ['Python 3.9', 'Python 3.10']

    @zooba
    Copy link
    Member Author

    zooba commented Nov 12, 2020

    Now that the 64-bit download is the default on python.org, we should make the build command default to 64-bit as well.

    This should only affect contributors, so should be non-controversial. But we should add a "-x86" option to the batch file as well.

    @zooba zooba added 3.9 only security fixes 3.10 only security fixes build The build process and cross-build OS-windows labels Nov 12, 2020
    @tim-one
    Copy link
    Member

    tim-one commented Nov 12, 2020

    +1. If you're feeling more ambitious, it would also be good to change build.bat and rt.bat to use the same "which platform?" spellings and with the same defaults.

    @zooba
    Copy link
    Member Author

    zooba commented Nov 13, 2020

    I hope you'll find that PR suitable ambitious :)

    It would really be nice to have proper Powershell scripts for these, but that would be a more significant rewrite (and probably require changing argument names...). I'm not *that* ambitious.

    @zooba
    Copy link
    Member Author

    zooba commented Nov 18, 2020

    New changeset 2156d96 by Steve Dower in branch 'master':
    bpo-42336: Improve PCbuild batch files (GH-23275)
    2156d96

    @zooba
    Copy link
    Member Author

    zooba commented Nov 18, 2020

    New changeset 8b1f4cc by Steve Dower in branch '3.8':
    bpo-42336: Improve PCbuild batch files (GH-23325)
    8b1f4cc

    @miss-islington
    Copy link
    Contributor

    New changeset 37f6fe2 by Miss Islington (bot) in branch '3.9':
    bpo-42336: Improve PCbuild batch files (GH-23275)
    37f6fe2

    @ned-deily
    Copy link
    Member

    New changeset 9ae1742 by Steve Dower in branch '3.7':
    [3.7] bpo-42336: Improve PCbuild batch files (GH-23325) (GH-23373)
    9ae1742

    @zooba
    Copy link
    Member Author

    zooba commented Nov 21, 2020

    We also updated the buildbot config to use the new options.

    @zooba zooba closed this as completed Nov 21, 2020
    @zooba zooba self-assigned this Nov 21, 2020
    @zooba zooba closed this as completed Nov 21, 2020
    @zooba zooba self-assigned this Nov 21, 2020
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes build The build process and cross-build OS-windows
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants