Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise overflow errors iso. deprecation warnings in socket.htons and socket.ntohs (was deprecated in 3.7) #86559

Closed
erlend-aasland opened this issue Nov 17, 2020 · 2 comments
Labels
3.10 stdlib type-bug

Comments

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Nov 17, 2020

BPO 42393
Nosy @serhiy-storchaka, @pablogsal, @erlend-aasland
PRs
  • #23980
  • Files
  • error_iso_warning.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-12-31.13:49:15.404>
    created_at = <Date 2020-11-17.20:56:09.612>
    labels = ['type-bug', 'library', '3.10']
    title = 'Raise overflow errors iso. deprecation warnings in socket.htons and socket.ntohs (was deprecated in 3.7)'
    updated_at = <Date 2020-12-31.13:49:15.404>
    user = 'https://github.com/erlend-aasland'

    bugs.python.org fields:

    activity = <Date 2020-12-31.13:49:15.404>
    actor = 'serhiy.storchaka'
    assignee = 'none'
    closed = True
    closed_date = <Date 2020-12-31.13:49:15.404>
    closer = 'serhiy.storchaka'
    components = ['Library (Lib)']
    creation = <Date 2020-11-17.20:56:09.612>
    creator = 'erlendaasland'
    dependencies = []
    files = ['49605']
    hgrepos = []
    issue_num = 42393
    keywords = ['patch']
    message_count = 2.0
    messages = ['381284', '384117']
    nosy_count = 3.0
    nosy_names = ['serhiy.storchaka', 'pablogsal', 'erlendaasland']
    pr_nums = ['23980']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue42393'
    versions = ['Python 3.10']

    @erlend-aasland
    Copy link
    Contributor Author

    @erlend-aasland erlend-aasland commented Nov 17, 2020

    Silent truncation was deprecated in Python 3.7 in bpo-28332 with commit 6a7d348 by Serhiy Storchaka. It should be ok to turn these into OverflowError's starting with Python 3.10.

    @erlend-aasland erlend-aasland added 3.10 stdlib type-bug labels Nov 17, 2020
    @serhiy-storchaka
    Copy link
    Member

    @serhiy-storchaka serhiy-storchaka commented Dec 31, 2020

    New changeset f4936ad by Erlend Egeberg Aasland in branch 'master':
    bpo-42393: Raise OverflowError iso. DeprecationWarning on overflow in socket.ntohs and socket.htons (GH-23980)
    f4936ad

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 stdlib type-bug
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants