Remove PyModule_GetWarningsModule() in pylifecycle.c

[shihai1991]

BPO	42599
Nosy	@vstinner, @encukou, @shihai1991
PRs	bpo-42599: Remove PyModule_GetWarningsModule() of pylifecycle.c #23691

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2020-12-08.14:46:53.031>
created_at = <Date 2020-12-08.11:25:12.837>
labels = ['interpreter-core', '3.10']
title = 'Remove PyModule_GetWarningsModule() in pylifecycle.c'
updated_at = <Date 2020-12-08.14:46:53.030>
user = 'https://github.com/shihai1991'

bugs.python.org fields:

activity = <Date 2020-12-08.14:46:53.030>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-12-08.14:46:53.031>
closer = 'vstinner'
components = ['Interpreter Core']
creation = <Date 2020-12-08.11:25:12.837>
creator = 'shihai1991'
dependencies = []
files = []
hgrepos = []
issue_num = 42599
keywords = ['patch']
message_count = 6.0
messages = ['382727', '382728', '382729', '382730', '382740', '382741']
nosy_count = 3.0
nosy_names = ['vstinner', 'petr.viktorin', 'shihai1991']
pr_nums = ['23691']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue42599'
versions = ['Python 3.10']

[shihai1991]

PyModule_GetWarningsModule() of pylifecycle.c is useless when _warning module was converted to a builtin module in 2.6. So move it directly now is OK.

[vstinner]

It's not part of the C API and it's no longer exported in libpython since we (the default visibility was changed to "hidden"). IMHO it's safe to remove the function. But it would not harm to document the removal in https://docs.python.org/dev/whatsnew/3.10.html#id4 section.

[shihai1991]

But it would not harm to document the removal in https://docs.python.org/dev/whatsnew/3.10.html#id4 section.

Copy that. I will update it soon.

[encukou]

When was the visibility changed to hidden?

[vstinner]

New changeset 0f91f58 by Hai Shi in branch 'master':
bpo-42599: Remove useless PyModule_GetWarningsModule() (GH-23691)
0f91f58

[vstinner]

When was the visibility changed to hidden?

In Python 3.9:

commit 0b60f64
Author: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Date: Tue Oct 15 08:26:12 2019 +0100

bpo-11410: Standardize and use symbol visibility attributes across POSIX and Windows. (GH-16347)

Symbols which are not declared with PyAPI_FUNC() are no longer exported when using GCC or clang (any compiler supporting -fvisibility=hidden).

PyModule_GetWarningsModule() was not documented nor exported.

I merged the PR. If it breaks too many packages, we can consider to revert the change. But I expect that there are zero project using it.

Note: PyModule_GetWarningsModule() was not part of PC/python3dll.c neither, hopefully ;-)