EXT_SUFFIX too short on FreeBSD and AIX

[mattip]

BPO	42604
Nosy	@vstinner, @mattip, @pablogsal, @miss-islington
PRs	bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using configure #23708 [3.9] bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using configure (GH-23708) #23866 [3.8] bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using configure (GH-23708) #23867

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-01-29.23:59:05.929>
created_at = <Date 2020-12-08.21:53:22.342>
labels = ['3.8', 'build', '3.7', '3.9', '3.10']
title = 'EXT_SUFFIX too short on FreeBSD and AIX'
updated_at = <Date 2021-01-29.23:59:05.929>
user = 'https://github.com/mattip'

bugs.python.org fields:

activity = <Date 2021-01-29.23:59:05.929>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2021-01-29.23:59:05.929>
closer = 'vstinner'
components = ['Build']
creation = <Date 2020-12-08.21:53:22.342>
creator = 'mattip'
dependencies = []
files = []
hgrepos = []
issue_num = 42604
keywords = ['patch']
message_count = 13.0
messages = ['382767', '383299', '383306', '383387', '383413', '383414', '383415', '383417', '385347', '385351', '385356', '385357', '385959']
nosy_count = 4.0
nosy_names = ['vstinner', 'mattip', 'pablogsal', 'miss-islington']
pr_nums = ['23708', '23866', '23867']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue42604'
versions = ['Python 3.7', 'Python 3.8', 'Python 3.9', 'Python 3.10']

[mattip]

Continuation of bpo-39825, this time for FreeBSD and AIX. As commented there, the test added in the fix to 39825 fails on FreeBSD and AIX:

FAIL: test_EXT_SUFFIX_in_vars (test.test_sysconfig.TestSysConfig)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/test/test_sysconfig.py", line 368, in test_EXT_SUFFIX_in_vars
    self.assertEqual(vars['EXT_SUFFIX'], _imp.extension_suffixes()[0])
AssertionError: '.so' != '.cpython-310d.so'
- .so
+ .cpython-310d.so

So somehow EXT_SUFFIX is being set to .so rather than .cpython-310d.so.

It seems the difference in EXT_SUFFIX comes from this stanza in configure:

case $ac_sys_system in
Linux*|GNU*|Darwin|VxWorks)
EXT_SUFFIX=.${SOABI}${SHLIB_SUFFIX};;
*)
EXT_SUFFIX=${SHLIB_SUFFIX};;
esac

where $ac_sys_system is uname -s. On FREEBSD, this is "FreeBSD", and I think on AIX it is "AIX". My preference would be to always set EXT_SUFFIX to ${SOABI}${SHLIB_SUFFIX}, with no option for setting it to a different value. Does that seem right?

[mattip]

vstinner: ping. Are merge builds still failing or can I close this?

[vstinner]

test_sysconfig still fails:

• POWER6 AIX 3.x: https://buildbot.python.org/all/#/builders/302/builds/563
• PPC64 AIX 3.x: https://buildbot.python.org/all/#/builders/438/builds/593
• AMD64 FreeBSD Shared 3.x: https://buildbot.python.org/all/#/builders/483/builds/572

[mattip]

The linked PR 23708 is meant to fix the failures. Any chance you can take a look?

[pablogsal]

New changeset a44ce6c by Matti Picus in branch 'master':
bpo-42604: always set EXT_SUFFIX=${SOABI}${SHLIB_SUFFIX} when using configure (GH-23708)
a44ce6c