Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distutils: Remove bdist_wininst command #86968

Closed
vstinner opened this issue Jan 1, 2021 · 7 comments
Closed

distutils: Remove bdist_wininst command #86968

vstinner opened this issue Jan 1, 2021 · 7 comments
Labels
3.10 stdlib

Comments

@vstinner
Copy link
Member

@vstinner vstinner commented Jan 1, 2021

BPO 42802
Nosy @vstinner, @jkloth, @merwok, @dstufft
PRs
  • #24043
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-01-08.23:38:15.530>
    created_at = <Date 2021-01-01.14:28:27.564>
    labels = ['library', '3.10']
    title = 'distutils: Remove bdist_wininst command'
    updated_at = <Date 2021-01-11.12:53:38.864>
    user = 'https://github.com/vstinner'

    bugs.python.org fields:

    activity = <Date 2021-01-11.12:53:38.864>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-01-08.23:38:15.530>
    closer = 'vstinner'
    components = ['Distutils']
    creation = <Date 2021-01-01.14:28:27.564>
    creator = 'vstinner'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 42802
    keywords = ['patch']
    message_count = 7.0
    messages = ['384173', '384175', '384179', '384180', '384181', '384696', '384832']
    nosy_count = 4.0
    nosy_names = ['vstinner', 'jkloth', 'eric.araujo', 'dstufft']
    pr_nums = ['24043']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue42802'
    versions = ['Python 3.10']

    @vstinner
    Copy link
    Member Author

    @vstinner vstinner commented Jan 1, 2021

    Attached PR removes it.

    The bdist_wininst command was deprecated in Python 3.8:

    commit 1da4462
    Author: Victor Stinner <vstinner@redhat.com>
    Date: Fri Jul 5 10:44:12 2019 +0200

    bpo-37481: Deprecate distutils bdist_wininst command (GH-14553)
    
    The distutils bdist_wininst command is now deprecated, use
    bdist_wheel (wheel packages) instead.
    

    "What’s New In Python 3.9: Build Changes" also announced:

    • On non-Windows platforms, creating ``bdist_wininst`` installers is now
      officially unsupported. (See :issue:`10945` for more details.)

    https://docs.python.org/dev/whatsnew/3.9.html#build-changes

    See bpo-37481 and:
    https://discuss.python.org/t/deprecate-bdist-wininst/1929

    @vstinner vstinner added 3.10 stdlib labels Jan 1, 2021
    @vstinner
    Copy link
    Member Author

    @vstinner vstinner commented Jan 1, 2021

    There are 19 issues (+ this one) on bdist_wininst. Once distutils bdist_wininst command will be removed, I propose to all these issues.

    Search for open issues with "bdist_wininst" in the title.

    Only bpo-41771 was active recently (3 months ago). The 18 other issues are inactive for between 18 months and 121 months (10 years!).

    @vstinner
    Copy link
    Member Author

    @vstinner vstinner commented Jan 1, 2021

    FYI last year, I fixed setuptools v45.2 (released in February 2020) when bdist_wininst is missing:
    pypa/setuptools@5d17586

    @vstinner
    Copy link
    Member Author

    @vstinner vstinner commented Jan 1, 2021

    Note: bdist_msi is deprecated since Python 3.9 (bpo-39586). I prefer to wait for Python 3.11 to remove it:

    commit 29b3fc0
    Author: Hugo van Kemenade <hugovk@users.noreply.github.com>
    Date: Mon Feb 10 15:26:40 2020 +0200

    bpo-39586: Deprecate distutils bdist_msi command (GH-18415)
    

    @vstinner
    Copy link
    Member Author

    @vstinner vstinner commented Jan 1, 2021

    I created a https://discuss.python.org/t/remove-bdist-wininst-command/6434 topic to check if anyone wants to keep the command, or if it's ok to remove it right now.

    @vstinner
    Copy link
    Member Author

    @vstinner vstinner commented Jan 8, 2021

    New changeset 0e2a0f7 by Victor Stinner in branch 'master':
    bpo-42802: Remove distutils bdist_wininst command (GH-24043)
    0e2a0f7

    @vstinner vstinner closed this as completed Jan 8, 2021
    @vstinner
    Copy link
    Member Author

    @vstinner vstinner commented Jan 11, 2021

    I closed the 19 open issues which contained "wininst" in their title as "wont fix" with the message:

    "The distutils bdist_wininst command has been removed in Python 3.10: see bpo-42802."

    You can simply search for closed issue which contains "wininst" in their title if you want to list them.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 stdlib
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant