Use PEP 590 vectorcall to speed up calls to filter()

[corona10]

BPO	43287
Nosy	@rhettinger, @vstinner, @corona10
PRs	bpo-43287: Use PEP 590 vectorcall to speed up filter() #24611
Files	filter_bench.py

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-03-10.16:40:19.794>
created_at = <Date 2021-02-21.17:59:22.986>
labels = ['interpreter-core', '3.10']
title = 'Use PEP 590 vectorcall to speed up calls to filter()'
updated_at = <Date 2021-03-10.16:40:19.794>
user = 'https://github.com/corona10'

bugs.python.org fields:

activity = <Date 2021-03-10.16:40:19.794>
actor = 'corona10'
assignee = 'none'
closed = True
closed_date = <Date 2021-03-10.16:40:19.794>
closer = 'corona10'
components = ['Interpreter Core']
creation = <Date 2021-02-21.17:59:22.986>
creator = 'corona10'
dependencies = []
files = ['49825']
hgrepos = []
issue_num = 43287
keywords = ['patch']
message_count = 7.0
messages = ['387469', '387470', '387482', '387490', '387493', '388355', '388443']
nosy_count = 3.0
nosy_names = ['rhettinger', 'vstinner', 'corona10']
pr_nums = ['24611']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue43287'
versions = ['Python 3.10']

[corona10]

+--------------+--------+----------------------+
| Benchmark | master | vectorcall |
+==============+========+======================+
| bench filter | 191 ns | 151 ns: 1.26x faster |
+--------------+--------+----------------------+

Like reversed(https://bugs.python.org/issue41922), it looks okay to update filter() to use PEP-590.

[rhettinger]

+0 I don't see any downside.

Note, the benchmark only times instantiation of the filter object. It doesn't actually run the iterator which is where most of the runtime cost is spent. So in actual code there is almost zero benefit. For example, add "list" to the statement: stmt="b = list(filter(lambda x: x % 2 == 0, a))" and the improvement disappears.

[corona10]

+0 I don't see any downside.

Thank you Raymond :)
I agree with your view, At first, I thought that instantiation time reducing is also meaningful and we already applied PEP-590 for some of the types to reduce instantiation. (e.g range(), list(), dict(), bool(), reversed(), type()..)

And also I thought that filter is one of the well-used features in Python so it was one of the candidates to apply from my sight. ;)

But if this PR only consume maintenance cost, I am okay with not to apply it doesn't matter :)

And happy new year Raymond(Sorry I am late ;) But the lunar new year was only 2weeks ago so not too late lol)

[rhettinger]

Happy new year to you as well :-)

[rhettinger]

FWIW, I don't think there is much of a maintenance burden; hence, the +0. You've already done the work.

[vstinner]

See also bpo-43447: "Generate vectorcall code to parse arguments using Argument Clinic".

[corona10]

New changeset 9a9c11a by Dong-hee Na in branch 'master':
bpo-43287: Use PEP-590 vectorcall to speed up filter() (GH-24611)
9a9c11a