-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sqlite3] Improve sqlite3_value_text() error handling #88019
Comments
Fix sqlite3_value_text() usage:
Quoting the SQLite docs: See also: |
The affected branch is exercised by the following tests:
I've expanded test_aggr_check_param_str and test_param_string to also check empty strings. |
I think it is worth to backport it to 3.9. It looks to me that it fixes also support of strings containing NUL. It would be nice to add corresponding tests for this. You can also add this in the NEWS entry for this issue. |
I'll add extra tests in a separate PR, so we can easily backport it to 3.10 and 3.9. |
What about new tests and NEWS update? |
Thanks for merging the NEWS amendments, Pablo. We can close this issue after landing PR 27642. |
Serhiy, I believe I've addressed your review remarks on PR 27642. Would you mind taking a look at it again if you have time? |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: