-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify urllib.parse_qsl #88145
Comments
Just noticed the following code in urrlib.parse_qsl: pairs = [s1 for s1 in qs.split(separator)]
for name_value in pairs:
... see Line 755 in 088a15c
This looks like an unnecessary list comprehension to me, probably a relic of earlier code that used a nested list comprehension for splitting with two different separators. Can't we just do this instead now, which is faster and shorter? for name_value qs.split(separator): I can provide a PR if wanted. |
Seems like a nice simplification to me. Can I open PR? :) |
Please submit the PR if you want |
I saw you submitted a PR already which looks good to me. |
I should care that you can have a chance to submit the patch :) |
I don't mind if you reopen your PR. But thanks for asking. |
I add your name as the co-author on PR 25756 :) |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: