_Random.seed() is called twice

[serhiy-storchaka]

BPO	44260
Nosy	@rhettinger, @mdickinson, @serhiy-storchaka
PRs	bpo-44260: Do not read system entropy without need in Random() #26455

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-05-31.20:24:57.127>
created_at = <Date 2021-05-28.14:27:28.976>
labels = ['extension-modules', '3.11']
title = '_Random.seed() is called twice'
updated_at = <Date 2021-05-31.20:24:57.126>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2021-05-31.20:24:57.126>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2021-05-31.20:24:57.127>
closer = 'serhiy.storchaka'
components = ['Extension Modules']
creation = <Date 2021-05-28.14:27:28.976>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 44260
keywords = ['patch']
message_count = 3.0
messages = ['394663', '394754', '394823']
nosy_count = 3.0
nosy_names = ['rhettinger', 'mark.dickinson', 'serhiy.storchaka']
pr_nums = ['26455']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue44260'
versions = ['Python 3.11']

[serhiy-storchaka]

_Random.seed() is called twice: first it is called in _Random.__new__(), then it is called in Random.__init__(). By default it reads system enthropy, so it consumes global system resource without need.

[rhettinger]

Consider moving seeding from _random.Random.__new__ to _random.Random.__init__. Since random.Random.__init__ doesn't call the super(), the C version never gets called, avoiding the double seeding. But, it still lets _random.Random function as a standalone class.

[serhiy-storchaka]

New changeset a6a2065 by Serhiy Storchaka in branch 'main':
bpo-44260: Do not read system entropy without need in Random() (GH-26455)
a6a2065