Duplicate symbol _BUFFER_BLOCK_SIZE when statically linking multiple modules

[freakboy3742]

BPO	44458
Nosy	@gpshead, @freakboy3742, @animalize, @miss-islington
PRs	bpo-44458: Ensure BUFFER_BLOCK_SIZE symbol is statically allocated. #26808 [3.10] bpo-44458: Ensure BUFFER_BLOCK_SIZE symbol is statically allocated. (GH-26808) #26844

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/gpshead'
closed_at = <Date 2021-06-22.07:12:19.493>
created_at = <Date 2021-06-19.03:24:49.696>
labels = ['extension-modules', 'build', '3.10', '3.11']
title = 'Duplicate symbol _BUFFER_BLOCK_SIZE when statically linking multiple modules'
updated_at = <Date 2021-06-22.07:12:19.492>
user = 'https://github.com/freakboy3742'

bugs.python.org fields:

activity = <Date 2021-06-22.07:12:19.492>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2021-06-22.07:12:19.493>
closer = 'gregory.p.smith'
components = ['Extension Modules']
creation = <Date 2021-06-19.03:24:49.696>
creator = 'freakboy3742'
dependencies = []
files = []
hgrepos = []
issue_num = 44458
keywords = ['patch']
message_count = 4.0
messages = ['396114', '396308', '396310', '396311']
nosy_count = 4.0
nosy_names = ['gregory.p.smith', 'freakboy3742', 'malin', 'miss-islington']
pr_nums = ['26808', '26844']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue44458'
versions = ['Python 3.10', 'Python 3.11']

[freakboy3742]

BPO-41486 added _BlocksOutputBuffer for the bz2, lzma and zlib module.

Part of this patch included a new header file, pycore_blocks_output_buffer.h, which defines a BUFFER_BLOCK_SIZE constant.

If two or more of the bz2, lzma or zlib modules are compiled as statically linked modules (i.e., added to Lib/Setup.local), this results in a duplicate symbol error when the Python executable is linked:

duplicate symbol '_BUFFER_BLOCK_SIZE' in:
    libpython3.10.a(_bz2module.o)
    libpython3.10.a(_lzmamodule.o)
duplicate symbol '_BUFFER_BLOCK_SIZE' in:
    libpython3.10.a(_bz2module.o)
    libpython3.10.a(zlibmodule.o)

[gpshead]

New changeset 92c2e91 by Russell Keith-Magee in branch 'main':
bpo-44458: Ensure BUFFER_BLOCK_SIZE symbol is statically allocated. (GH-26808)
92c2e91

[gpshead]

New changeset cf73933 by Miss Islington (bot) in branch '3.10':
bpo-44458: Ensure BUFFER_BLOCK_SIZE symbol is statically allocated. (GH-26808) (GH-26844)
cf73933

[gpshead]

Good catch. We don't have buildbots statically linking the modules in these days, that'd be useful to prevent things like this from happening.