Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ltrace functionality doesn't work if there is an exception set #88638

Closed
pablogsal opened this issue Jun 21, 2021 · 4 comments
Closed

ltrace functionality doesn't work if there is an exception set #88638

pablogsal opened this issue Jun 21, 2021 · 4 comments

Comments

@pablogsal
Copy link
Member

BPO 44472
Nosy @ambv, @pablogsal, @miss-islington
PRs
  • bpo-44472: Fix ltrace functionality when exceptions are raised #26822
  • [3.10] bpo-44472: Fix ltrace functionality when exceptions are raised (GH-26822) #26830
  • [3.9] bpo-44472: Fix ltrace functionality when exceptions are raised (GH-26822) #26831
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-06-21.15:25:49.615>
    created_at = <Date 2021-06-21.10:18:55.054>
    labels = []
    title = "ltrace functionality doesn't work if there is an exception set"
    updated_at = <Date 2021-07-13.08:43:58.614>
    user = 'https://github.com/pablogsal'

    bugs.python.org fields:

    activity = <Date 2021-07-13.08:43:58.614>
    actor = 'pablogsal'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-06-21.15:25:49.615>
    closer = 'pablogsal'
    components = []
    creation = <Date 2021-06-21.10:18:55.054>
    creator = 'pablogsal'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 44472
    keywords = ['patch']
    message_count = 4.0
    messages = ['396220', '396252', '397323', '397388']
    nosy_count = 3.0
    nosy_names = ['lukasz.langa', 'pablogsal', 'miss-islington']
    pr_nums = ['26822', '26830', '26831']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue44472'
    versions = []

    @pablogsal
    Copy link
    Member Author

    Using lltrace results in this crash because we are getting the repl with an exception set:

    pop None
    Assertion failed: (!_PyErr_Occurred(tstate)), function PyObject_Repr, file Objects/object.c, line 431.
    pop Fatal Python error: Aborted

    Current thread 0x00000001060eddc0 (most recent call first):
    File "/Users/pgalindo3/github/cpython/Lib/test/test_sys_settrace.py", line 1999 in gen
    File "/Users/pgalindo3/github/cpython/Lib/test/test_sys_settrace.py", line 2001 in test_jump_from_yield
    File "/Users/pgalindo3/github/cpython/Lib/test/test_sys_settrace.py", line 1248 in run_test
    File "/Users/pgalindo3/github/cpython/Lib/test/test_sys_settrace.py", line 1276 in test
    File "/Users/pgalindo3/github/cpython/Lib/unittest/case.py", line 549 in _callTestMethod
    File "/Users/pgalindo3/github/cpython/Lib/unittest/case.py", line 592 in run
    File "/Users/pgalindo3/github/cpython/Lib/unittest/case.py", line 652 in __call__
    File "/Users/pgalindo3/github/cpython/Lib/unittest/suite.py", line 122 in run
    File "/Users/pgalindo3/github/cpython/Lib/unittest/suite.py", line 84 in __call__
    File "/Users/pgalindo3/github/cpython/Lib/unittest/suite.py", line 122 in run
    File "/Users/pgalindo3/github/cpython/Lib/unittest/suite.py", line 84 in __call__
    File "/Users/pgalindo3/github/cpython/Lib/unittest/suite.py", line 122 in run
    File "/Users/pgalindo3/github/cpython/Lib/unittest/suite.py", line 84 in __call__
    File "/Users/pgalindo3/github/cpython/Lib/unittest/runner.py", line 176 in run
    File "/Users/pgalindo3/github/cpython/Lib/test/support/init.py", line 960 in _run_suite
    File "/Users/pgalindo3/github/cpython/Lib/test/support/init.py", line 1083 in run_unittest
    File "/Users/pgalindo3/github/cpython/Lib/test/libregrtest/runtest.py", line 210 in _test_module
    File "/Users/pgalindo3/github/cpython/Lib/test/libregrtest/runtest.py", line 246 in _runtest_inner2
    File "/Users/pgalindo3/github/cpython/Lib/test/libregrtest/runtest.py", line 282 in _runtest_inner
    File "/Users/pgalindo3/github/cpython/Lib/test/libregrtest/runtest.py", line 154 in _runtest
    File "/Users/pgalindo3/github/cpython/Lib/test/libregrtest/runtest.py", line 194 in runtest
    File "/Users/pgalindo3/github/cpython/Lib/test/libregrtest/main.py", line 423 in run_tests_sequential
    File "/Users/pgalindo3/github/cpython/Lib/test/libregrtest/main.py", line 521 in run_tests
    File "/Users/pgalindo3/github/cpython/Lib/test/libregrtest/main.py", line 694 in _main
    File "/Users/pgalindo3/github/cpython/Lib/test/libregrtest/main.py", line 641 in main
    File "/Users/pgalindo3/github/cpython/Lib/test/libregrtest/main.py", line 719 in main
    File "/Users/pgalindo3/github/cpython/Lib/test/main.py", line 2 in <module>
    File "/Users/pgalindo3/github/cpython/Lib/runpy.py", line 86 in _run_code
    File "/Users/pgalindo3/github/cpython/Lib/runpy.py", line 196 in _run_module_as_main

    @pablogsal
    Copy link
    Member Author

    New changeset 06cda80 by Pablo Galindo in branch 'main':
    bpo-44472: Fix ltrace functionality when exceptions are raised (GH-26822)
    06cda80

    @ambv
    Copy link
    Contributor

    ambv commented Jul 12, 2021

    New changeset 6fb4248 by Miss Islington (bot) in branch '3.9':
    bpo-44472: Fix ltrace functionality when exceptions are raised (GH-26822) (bpo-26831)
    6fb4248

    @pablogsal
    Copy link
    Member Author

    New changeset 4a0f1df by Miss Islington (bot) in branch '3.10':
    bpo-44472: Fix ltrace functionality when exceptions are raised (GH-26822) (GH-26830)
    4a0f1df

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants