Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing docs: Mention PEP 604 syntax more prominently #89120

Closed
srittau mannequin opened this issue Aug 19, 2021 · 6 comments
Closed

typing docs: Mention PEP 604 syntax more prominently #89120

srittau mannequin opened this issue Aug 19, 2021 · 6 comments
Labels
3.10 only security fixes 3.11 bug and security fixes docs Documentation in the Doc dir

Comments

@srittau
Copy link
Mannequin

srittau mannequin commented Aug 19, 2021

BPO 44957
Nosy @gvanrossum, @srittau, @ambv, @miss-islington, @Fidget-Spinner
PRs
  • bpo-44957: Promote PEP 604 syntax in typing docs #27833
  • [3.10] bpo-44957: Promote PEP 604 syntax in typing docs (GH-27833) #27897
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-08-22.20:05:09.877>
    created_at = <Date 2021-08-19.13:50:37.936>
    labels = ['3.11', '3.10', 'docs']
    title = 'typing docs: Mention PEP 604 syntax more prominently'
    updated_at = <Date 2021-08-22.20:05:09.876>
    user = 'https://github.com/srittau'

    bugs.python.org fields:

    activity = <Date 2021-08-22.20:05:09.876>
    actor = 'lukasz.langa'
    assignee = 'docs@python'
    closed = True
    closed_date = <Date 2021-08-22.20:05:09.877>
    closer = 'lukasz.langa'
    components = ['Documentation']
    creation = <Date 2021-08-19.13:50:37.936>
    creator = 'srittau'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 44957
    keywords = ['patch']
    message_count = 6.0
    messages = ['399919', '399921', '399925', '399926', '400092', '400102']
    nosy_count = 6.0
    nosy_names = ['gvanrossum', 'srittau', 'docs@python', 'lukasz.langa', 'miss-islington', 'kj']
    pr_nums = ['27833', '27897']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue44957'
    versions = ['Python 3.10', 'Python 3.11']

    @srittau
    Copy link
    Mannequin Author

    srittau mannequin commented Aug 19, 2021

    The new PEP-604 syntax for type unions should be mentioned more prominently in the typing docs, starting with Python 3.10. I'm preparing a PR for discussion.

    @srittau srittau mannequin added 3.10 only security fixes 3.11 bug and security fixes labels Aug 19, 2021
    @srittau srittau mannequin assigned docspython Aug 19, 2021
    @srittau srittau mannequin added docs Documentation in the Doc dir 3.10 only security fixes 3.11 bug and security fixes labels Aug 19, 2021
    @srittau srittau mannequin assigned docspython Aug 19, 2021
    @srittau srittau mannequin added the docs Documentation in the Doc dir label Aug 19, 2021
    @gvanrossum
    Copy link
    Member

    Ken, this sounds like a good idea. Can you help?

    @Fidget-Spinner
    Copy link
    Member

    Sure. Sebastian has created a really thorough PR at #72020 and I like it (with only one point for discussion).

    @gvanrossum
    Copy link
    Member

    Thanks to both of you!!

    @ambv
    Copy link
    Contributor

    ambv commented Aug 22, 2021

    New changeset dabb6e8 by Sebastian Rittau in branch 'main':
    bpo-44957: Promote PEP-604 syntax in typing docs (GH-27833)
    dabb6e8

    @ambv
    Copy link
    Contributor

    ambv commented Aug 22, 2021

    Thanks, Sebastian! ✨ 🍰 ✨

    @ambv ambv closed this as completed Aug 22, 2021
    @ambv ambv closed this as completed Aug 22, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 only security fixes 3.11 bug and security fixes docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants