http.client.HTTPConnection doesn't work without TCP_NODELAY

[rtobar]

BPO	45328
Nosy	@ambv, @miss-islington, @rtobar, @rtobar
PRs	bpo-45328: Avoid failure in OSs without TCP_NODELAY support #28646 [3.9] bpo-45328: Avoid failure in OSs without TCP_NODELAY support (GH-28646) #28770 [3.10] bpo-45328: Avoid failure in OSs without TCP_NODELAY support (GH-28646) #28771
Files	http-client.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-10-06.18:30:23.481>
created_at = <Date 2021-09-30.08:06:56.975>
labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
title = "http.client.HTTPConnection doesn't work without TCP_NODELAY"
updated_at = <Date 2021-10-06.18:30:23.480>
user = 'https://github.com/rtobar'

bugs.python.org fields:

activity = <Date 2021-10-06.18:30:23.480>
actor = 'lukasz.langa'
assignee = 'none'
closed = True
closed_date = <Date 2021-10-06.18:30:23.481>
closer = 'lukasz.langa'
components = ['Library (Lib)']
creation = <Date 2021-09-30.08:06:56.975>
creator = 'rtobar2'
dependencies = []
files = ['50316']
hgrepos = []
issue_num = 45328
keywords = ['patch']
message_count = 5.0
messages = ['402937', '403328', '403329', '403330', '403331']
nosy_count = 4.0
nosy_names = ['lukasz.langa', 'miss-islington', 'rtobar', 'rtobar2']
pr_nums = ['28646', '28770', '28771']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue45328'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[rtobar]

I'm working on trying to run python under SerenityOS.

At the moment, SerenityOS doesn't implement the TCP_NODELAY socket option. This makes the HTTPConnection.connect() method raise an OSError for an operation that is otherwise optional. Additionally, the connection object can be left in an intermediate state: the underlying socket is always created, but depending on what method was invoked (either connect() directly or a higher-level one such as putrequest()) the connection object can be in IDLE or REQ_STARTED state.

I have a patch that works (attached), and I'll be working on submitting a PR now.

Usage of TCP_NODELAY was introduced in 3.5 (bpo-23302), so even though I've been testing against 3.10rc2 for the time being I'm sure it will affect all versions in between.

[ambv]

New changeset 0571b93 by rtobar in branch 'main':
bpo-45328: Avoid failure in OSs without TCP_NODELAY support (GH-28646)
0571b93

[ambv]

New changeset 4c35a2a by Miss Islington (bot) in branch '3.10':
bpo-45328: Avoid failure in OSs without TCP_NODELAY support (GH-28646) (GH-28771)
4c35a2a

[ambv]

New changeset 92018a0 by Miss Islington (bot) in branch '3.9':
bpo-45328: Avoid failure in OSs without TCP_NODELAY support (GH-28646) (GH-28770)
92018a0

[ambv]

Thanks, rtobar! ✨ 🍰 ✨