-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python -m test -jN: write stderr in stdout to get messages in order #89573
Comments
In buildbot logs, when a worker process is run, two pipes are created for stdout and stderr. The problem is that using two pipes produce an output which is hard to read. Pseudo output: I would prefer: Real logs: 0:01:10 load avg: 4.48 [236/427/1] test_ftplib failed (env changed) -- (...)
Warning -- Uncaught thread exception: Exception
Exception in thread Thread-67:
Traceback (most recent call last):
(...)
Exception
test__all__ (test.test_ftplib.MiscTestCase) ... ok
test_abort (test.test_ftplib.TestFTPClass) ... ok
test_acct (test.test_ftplib.TestFTPClass) ... ok
test_all_errors (test.test_ftplib.TestFTPClass) ... ok
(...)
Ran 94 tests in 2.326s The Warning is logged at the beginning, it's not possible to know which test emitted this warning. I propose to write stdout and stderr of a worker process into a single pipe to keep messages order. In the past, I saw buildbot logging stderr messages in a different color. But it no longer seems to be the case. I'm working on a PR. |
Sadly, a recent build failure (at commit 560a79f) still write "Uncaught thread exception" at the top of logs: |
Calling sys.stdout doesn't help :-( Fail at commit ce3489c: The warning cannot come from MiscTestCase.test__all__(), so the warning is still logged at the wrong place. |
Oh. Sadly, with this change, faulthandler is no longer able to dump a traceback on a crash :-( |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: