Modules/makesetup uses wrong CFLAGS for *shared*

[tiran]

BPO	45571
Nosy	@Yhg1s, @brettcannon, @vstinner, @tiran, @miss-islington
PRs	bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161) #29161 [3.10] bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161) #29168 [3.9] bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161) #29169

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-10-22.19:12:54.170>
created_at = <Date 2021-10-22.13:21:54.015>
labels = ['3.10', 'type-bug', '3.9', 'build', '3.11']
title = 'Modules/makesetup uses wrong CFLAGS for *shared*'
updated_at = <Date 2021-10-22.19:12:54.170>
user = 'https://github.com/tiran'

bugs.python.org fields:

activity = <Date 2021-10-22.19:12:54.170>
actor = 'christian.heimes'
assignee = 'none'
closed = True
closed_date = <Date 2021-10-22.19:12:54.170>
closer = 'christian.heimes'
components = ['Build']
creation = <Date 2021-10-22.13:21:54.015>
creator = 'christian.heimes'
dependencies = []
files = []
hgrepos = []
issue_num = 45571
keywords = ['patch']
message_count = 4.0
messages = ['404766', '404804', '404807', '404810']
nosy_count = 5.0
nosy_names = ['twouters', 'brett.cannon', 'vstinner', 'christian.heimes', 'miss-islington']
pr_nums = ['29161', '29168', '29169']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue45571'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[tiran]

I think that makesetup uses the wrong CFLAGS variable for shared modules. The script uses PY_CFLAGS:

no)     cc="$cc \$(CCSHARED) \$(PY_CFLAGS) \$(PY_CPPFLAGS)";;

while setup.py uses PY_CFLAGS_NODIST:

    set_compiler_flags('CFLAGS', 'PY_CFLAGS_NODIST')

The flags are similar but not equal. Amongst others PY_CFLAGS does not include Include/internal while PY_CFLAGS_NODIST has -I./Include/internal.

[tiran]

New changeset f6e8b80 by Christian Heimes in branch 'main':
bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161)
f6e8b80

[miss-islington]

New changeset 1990308 by Miss Islington (bot) in branch '3.10':
bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161)
1990308

[miss-islington]

New changeset 269bf56 by Miss Islington (bot) in branch '3.9':
bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161)
269bf56