Missing tests for the dis module

[nanjekyejoannah]

BPO	45578
Nosy	@taleinat, @ambv, @corona10, @nanjekyejoannah, @sobolevn
PRs	bpo-45578: add tests for dis.distb #29332 [3.10] bpo-45578: add tests for dis.distb (GH-29332) #29385 [3.9] bpo-45578: add tests for dis.distb (GH-29332) #29386 bpo-45578: add a test case for dis.findlabels #30058

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2022-01-26.12:39:55.835>
created_at = <Date 2021-10-22.18:15:58.685>
labels = ['tests', '3.11']
title = 'Missing tests for the dis module'
updated_at = <Date 2022-01-26.12:39:55.831>
user = 'https://github.com/nanjekyejoannah'

bugs.python.org fields:

activity = <Date 2022-01-26.12:39:55.831>
actor = 'taleinat'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-26.12:39:55.835>
closer = 'taleinat'
components = ['Tests']
creation = <Date 2021-10-22.18:15:58.685>
creator = 'nanjekyejoannah'
dependencies = []
files = []
hgrepos = []
issue_num = 45578
keywords = ['patch']
message_count = 12.0
messages = ['404805', '404809', '404811', '405370', '405373', '405374', '405618', '405622', '405625', '405631', '411726', '411745']
nosy_count = 5.0
nosy_names = ['taleinat', 'lukasz.langa', 'corona10', 'nanjekyejoannah', 'sobolevn']
pr_nums = ['29332', '29385', '29386', '30058']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue45578'
versions = ['Python 3.11']

[nanjekyejoannah]

I don't see any tests for the following:

dis.distb
dis.findlabels

They are documented, I wonder if it was intentional.

dis.findlabels is also not dicumented.

[nanjekyejoannah]

maybe the latter is not a public function.

[nanjekyejoannah]

It looks like it actually

[sobolevn]

I would like to work on it! :)

Going to send a PR today.

[sobolevn]

Looks like findlabels is documented: https://docs.python.org/3/library/dis.html#dis.findlabels

[nanjekyejoannah]

Yes, it is that's why I added the clarity "It looks like it *is* actually" above

[ambv]

New changeset e346f19 by Nikita Sobolev in branch 'main':
bpo-45578: add tests for dis.distb (GH-29332)
e346f19

[sobolevn]

Only findlabels tests are left!

[ambv]

New changeset fd6b70d by Łukasz Langa in branch '3.10':
[3.10] bpo-45578: add tests for dis.distb (GH-29332) (GH-29385)
fd6b70d

[ambv]

New changeset 8198617 by Łukasz Langa in branch '3.9':
[3.9] bpo-45578: add tests for dis.distb (GH-29332) (bpo-29386)
8198617

[corona10]

New changeset 84f0939 by Nikita Sobolev in branch 'main':
bpo-45578: add a test case for dis.findlabels (GH-30058)
84f0939

[taleinat]

Thanks for your work on this Nikita!