Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlib_module_names.h is missing _scproxy #89851

Closed
tiran opened this issue Nov 2, 2021 · 6 comments
Closed

stdlib_module_names.h is missing _scproxy #89851

tiran opened this issue Nov 2, 2021 · 6 comments
Labels
3.10 only security fixes 3.11 bug and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@tiran
Copy link
Member

tiran commented Nov 2, 2021

BPO 45688
Nosy @gvanrossum, @vstinner, @tiran, @ericsnowcurrently, @miss-islington
PRs
  • bpo-45688: Add _scproxy to sys.stdlib_module_names (GH-29358) #29358
  • [3.10] bpo-45688: Add _scproxy to sys.stdlib_module_names (GH-29358) (GH-29361) #29361
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-11-02.11:32:48.875>
    created_at = <Date 2021-11-02.08:24:05.577>
    labels = ['type-bug', '3.10', 'build', '3.11']
    title = 'stdlib_module_names.h is missing _scproxy'
    updated_at = <Date 2021-11-08.17:05:56.308>
    user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2021-11-08.17:05:56.308>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-11-02.11:32:48.875>
    closer = 'christian.heimes'
    components = ['Build']
    creation = <Date 2021-11-02.08:24:05.577>
    creator = 'christian.heimes'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45688
    keywords = ['patch']
    message_count = 6.0
    messages = ['405495', '405502', '405504', '405510', '405963', '405965']
    nosy_count = 5.0
    nosy_names = ['gvanrossum', 'vstinner', 'christian.heimes', 'eric.snow', 'miss-islington']
    pr_nums = ['29358', '29361']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue45688'
    versions = ['Python 3.10', 'Python 3.11']

    @tiran
    Copy link
    Member Author

    tiran commented Nov 2, 2021

    stdlib_module_names.h is missing the macOS specific module _scproxy.
    Guido ran into the problem in PR #29118

    @tiran tiran added 3.10 only security fixes 3.11 bug and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error labels Nov 2, 2021
    @tiran
    Copy link
    Member Author

    tiran commented Nov 2, 2021

    New changeset 3409899 by Christian Heimes in branch 'main':
    bpo-45688: Add _scproxy to sys.stdlib_module_names (GH-29358)
    3409899

    @tiran
    Copy link
    Member Author

    tiran commented Nov 2, 2021

    New changeset b2ae631 by Miss Islington (bot) in branch '3.10':
    [3.10] bpo-45688: Add _scproxy to sys.stdlib_module_names (GH-29358) (GH-29361)
    b2ae631

    @tiran tiran closed this as completed Nov 2, 2021
    @tiran tiran closed this as completed Nov 2, 2021
    @gvanrossum
    Copy link
    Member

    Thanks!

    @vstinner
    Copy link
    Member

    vstinner commented Nov 8, 2021

    Oh right, Tools/scripts/generate_stdlib_module_names.py runs "./python setup.py -q build --list-module-names" which skips modules which are only built on specific platforms. On the Python CI, generate_stdlib_module_names.py is run on Linux.

    Nicely spotted, and thanks for the fix!

    Oh, it's hard to really know what the "stdlib" contains ;-)

    @vstinner
    Copy link
    Member

    vstinner commented Nov 8, 2021

    On Python 3.11.0a2+, I now get:

    $ ./python -c 'import sys; print(len(sys.stdlib_module_names))'
    304

    One more module ;-)

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 only security fixes 3.11 bug and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants