Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Deep-freeze": skip the marshal step by generating C code #89859

Closed
gvanrossum opened this issue Nov 3, 2021 · 3 comments
Closed

"Deep-freeze": skip the marshal step by generating C code #89859

gvanrossum opened this issue Nov 3, 2021 · 3 comments
Assignees
Labels
3.11 bug and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@gvanrossum
Copy link
Member

BPO 45696
Nosy @gvanrossum, @tiran, @ericsnowcurrently
PRs
  • bpo-45696: Deep-freeze #29118
  • bpo-45696: Use a stamp file to speed up rebuild #29522
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gvanrossum'
    closed_at = None
    created_at = <Date 2021-11-03.00:16:36.166>
    labels = ['interpreter-core', '3.11']
    title = '"Deep-freeze": skip the marshal step by generating C code'
    updated_at = <Date 2021-11-11.13:02:53.229>
    user = 'https://github.com/gvanrossum'

    bugs.python.org fields:

    activity = <Date 2021-11-11.13:02:53.229>
    actor = 'christian.heimes'
    assignee = 'gvanrossum'
    closed = False
    closed_date = None
    closer = None
    components = ['Interpreter Core']
    creation = <Date 2021-11-03.00:16:36.166>
    creator = 'gvanrossum'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45696
    keywords = ['patch']
    message_count = 3.0
    messages = ['405570', '406131', '406142']
    nosy_count = 3.0
    nosy_names = ['gvanrossum', 'christian.heimes', 'eric.snow']
    pr_nums = ['29118', '29522']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue45696'
    versions = ['Python 3.11']

    @gvanrossum
    Copy link
    Member Author

    See faster-cpython/ideas#84

    This appears to improve startup time by another 10% or more compared to main.

    @gvanrossum gvanrossum added the 3.11 bug and security fixes label Nov 3, 2021
    @gvanrossum gvanrossum self-assigned this Nov 3, 2021
    @gvanrossum gvanrossum added interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.11 bug and security fixes labels Nov 3, 2021
    @gvanrossum gvanrossum self-assigned this Nov 3, 2021
    @gvanrossum gvanrossum added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Nov 3, 2021
    @gvanrossum
    Copy link
    Member Author

    After PR 29118 is merged we get the benefits on UNIXy systems. We have several TODOs left then:

    • (Definitely:) Generate Windows build files

    • (Probably:) Find a way to avoid having to regenerate everything whenever any source file changes (any source file -> _bootstrap_python -> all generated files)

    • (Maybe:) Consider putting all generated code together in one file, for more savings (and build simplification)

    @gvanrossum
    Copy link
    Member Author

    New changeset 1cbaa50 by Guido van Rossum in branch 'main':
    bpo-45696: Deep-freeze selected modules (GH-29118)
    1cbaa50

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 bug and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs)
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants