-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
./python -m test --help output for refleaks seems wrong #89908
Comments
Just preparing to make a refleaks test run, so I ran: ./python -m test --help The output related to refleaks seemed suspicious: ... It's not obvious that "--fail-env-changed" has anything to do with "--findleaks". Does the -l/--findleaks message need to be corrected? |
IIUC you're looking for --huntrleaks/-R, not the unrelated --findleaks/-l: In that -m test -h menu: -l, --findleaks deprecated alias to --fail-env-changed -R RUNCOUNTS, --huntrleaks RUNCOUNTS |
Thanks, I get that. My issue is with the apparent mismatch between the English meaning of "find leaks" and "fail env changed." It seems to me that the help message(s) for one or both of those options is probably incorrect and needs to be changed. |
That's probably why --findleaks was deprecated (in 3.8, PR12951). We could remove it now. + vstinner |
In Python 3.6, regrtest failed if --findleaks was used and gc.garbage was not empty after a test completed. I modified regrtest to always run this check: --findleaks is now ignored. But I also modified --findleaks to make it an alias to the --fail-env-changed option: non-zero exit code if a test fails with "ENV CHANGED" status. I wrote PR 29514 to clarify the situation: remove --findleaks :-) |
To check for reference leaks, memory leaks and file descriptor leaks: --huntrleaks/-R should be used. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: