Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetBSD: ossaudio support incomplete #90211

Closed
0-wiz-0 mannequin opened this issue Dec 11, 2021 · 3 comments
Closed

NetBSD: ossaudio support incomplete #90211

0-wiz-0 mannequin opened this issue Dec 11, 2021 · 3 comments
Labels
3.10 only security fixes 3.11 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement

Comments

@0-wiz-0
Copy link
Mannequin

0-wiz-0 mannequin commented Dec 11, 2021

BPO 46053
Nosy @0-wiz-0
PRs
  • bpo-46053: Fix OSS audio support on NetBSD #30065
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2021-12-11.23:15:12.643>
    labels = ['extension-modules', 'type-feature', '3.11']
    title = 'NetBSD: ossaudio support incomplete'
    updated_at = <Date 2022-01-14.18:02:04.881>
    user = 'https://github.com/0-wiz-0'

    bugs.python.org fields:

    activity = <Date 2022-01-14.18:02:04.881>
    actor = 'wiz'
    assignee = 'none'
    closed = False
    closed_date = None
    closer = None
    components = ['Extension Modules']
    creation = <Date 2021-12-11.23:15:12.643>
    creator = 'wiz'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 46053
    keywords = ['patch']
    message_count = 2.0
    messages = ['408349', '410580']
    nosy_count = 1.0
    nosy_names = ['wiz']
    pr_nums = ['30065']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue46053'
    versions = ['Python 3.11']

    @0-wiz-0
    Copy link
    Mannequin Author

    0-wiz-0 mannequin commented Dec 11, 2021

    When compiling Python on NetBSD, the ossaudio module is not enabled.

    1. the code tries to export some #define that are not in the public OSS API (but that some other implementations provide)
    2. on NetBSD, you need to link against libossaudio when using OSS

    @0-wiz-0 0-wiz-0 mannequin added 3.11 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement labels Dec 11, 2021
    @0-wiz-0
    Copy link
    Mannequin Author

    0-wiz-0 mannequin commented Jan 14, 2022

    ping - this patch needs a review

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @AlexWaygood
    Copy link
    Member

    AlexWaygood commented Apr 18, 2022

    Closing as the linked PR has been merged 🥳 (cc. @0-wiz-0)

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.10 only security fixes 3.11 only security fixes extension-modules C modules in the Modules dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants