Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random.randrange removed support for non-integer types after just one release of deprecation #90782

Closed
hroncok mannequin opened this issue Feb 3, 2022 · 3 comments
Closed
Labels
3.11 only security fixes stdlib Python modules in the Lib dir

Comments

@hroncok
Copy link
Mannequin

hroncok mannequin commented Feb 3, 2022

BPO 46624
Nosy @rhettinger, @hroncok, @pablogsal
PRs
  • bpo-46624: Revert "Remove deprecated support for non-integer values" #31098
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2022-02-03.13:48:43.109>
    created_at = <Date 2022-02-03.10:52:01.049>
    labels = ['library', '3.11']
    title = 'random.randrange removed support for non-integer types after just one release of deprecation'
    updated_at = <Date 2022-02-03.13:48:43.109>
    user = 'https://github.com/hroncok'

    bugs.python.org fields:

    activity = <Date 2022-02-03.13:48:43.109>
    actor = 'rhettinger'
    assignee = 'none'
    closed = True
    closed_date = <Date 2022-02-03.13:48:43.109>
    closer = 'rhettinger'
    components = ['Library (Lib)']
    creation = <Date 2022-02-03.10:52:01.049>
    creator = 'hroncok'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 46624
    keywords = ['patch']
    message_count = 3.0
    messages = ['412436', '412437', '412442']
    nosy_count = 3.0
    nosy_names = ['rhettinger', 'hroncok', 'pablogsal']
    pr_nums = ['31098']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue46624'
    versions = ['Python 3.11']

    @hroncok
    Copy link
    Mannequin Author

    hroncok mannequin commented Feb 3, 2022

    In 5afa0a4 the support for non-integer types was removed from random.randrange().

    This change is not backward-compatible and it breaks 3rd party code, for example:

    simplewrap: https://bugzilla.redhat.com/show_bug.cgi?id=2050093
    numpy-stl: https://bugzilla.redhat.com/show_bug.cgi?id=2050092 == wolph/numpy-stl#188

    That support was only deprecated in Python 3.10 and it needs to remain deprecated for at least two Python releases. Please revert this change from Python 3.11 and wait for at least Python 3.12.

    See https://www.python.org/dev/peps/pep-0387/#making-incompatible-changes

    When you do remove this from Python 3.12, please make sure to document it in the What's new document.

    Thank you.

    @hroncok hroncok mannequin added 3.11 only security fixes stdlib Python modules in the Lib dir labels Feb 3, 2022
    @hroncok
    Copy link
    Mannequin Author

    hroncok mannequin commented Feb 3, 2022

    Proposed the revert at #31098

    @rhettinger
    Copy link
    Contributor

    New changeset 6baa98e by Miro Hrončok in branch 'main':
    bpo-46624: Defer to 3.12: "Remove deprecated support for non-integer values" (GH-31098)
    6baa98e

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 only security fixes stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant