Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests from asyncore to asyncio #91171

Closed
arhadthedev opened this issue Mar 14, 2022 · 3 comments
Closed

Update tests from asyncore to asyncio #91171

arhadthedev opened this issue Mar 14, 2022 · 3 comments
Labels
3.11 bug and security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@arhadthedev
Copy link
Member

BPO 47015
Nosy @josiahcarlson, @giampaolo, @asvetlov, @1st1, @arhadthedev
PRs
  • bpo-47015: Update test_os from asyncore to asyncio #31876
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2022-03-20.14:39:53.501>
    created_at = <Date 2022-03-14.20:38:01.268>
    labels = ['type-feature', 'tests', '3.11']
    title = 'Update tests from asyncore to asyncio'
    updated_at = <Date 2022-03-20.14:39:53.500>
    user = 'https://github.com/arhadthedev'

    bugs.python.org fields:

    activity = <Date 2022-03-20.14:39:53.500>
    actor = 'asvetlov'
    assignee = 'none'
    closed = True
    closed_date = <Date 2022-03-20.14:39:53.501>
    closer = 'asvetlov'
    components = ['Tests']
    creation = <Date 2022-03-14.20:38:01.268>
    creator = 'arhadthedev'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 47015
    keywords = ['patch']
    message_count = 3.0
    messages = ['415185', '415518', '415608']
    nosy_count = 6.0
    nosy_names = ['josiahcarlson', 'giampaolo.rodola', 'stutzbach', 'asvetlov', 'yselivanov', 'arhadthedev']
    pr_nums = ['31876']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue47015'
    versions = ['Python 3.11']

    @arhadthedev
    Copy link
    Member Author

    PEP-594 – Removing dead batteries from the standard library [1] removes asyncore and asynchat in 3.12 with the following note:

    The asyncore module is also used in stdlib tests. The tests for ftplib, logging, smptd, smtplib, and ssl are partly based on asyncore. These tests must be updated to use asyncio or threading.

    (Note: the tests for os module are not mentioned and smtpd will be removed in 3.12 along with its tests anyway)

    I'm performing the update now to avoid keeping asynchat and asyncore as private subpackages of test package.

    [1] https://peps.python.org/pep-0594/

    @arhadthedev arhadthedev added 3.11 bug and security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement labels Mar 14, 2022
    @arhadthedev
    Copy link
    Member Author

    The PR is ready for a review; I sorted out all bugs.

    @asvetlov
    Copy link
    Contributor

    New changeset 3ae975f by Oleg Iarygin in branch 'main':
    bpo-47015: Update test_os from asyncore to asyncio (GH-31876)
    3ae975f

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 bug and security fixes tests Tests in the Lib/test dir type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants