Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy pgort140.dll when building for PGO #91259

Closed
zooba opened this issue Mar 23, 2022 · 5 comments
Closed

Copy pgort140.dll when building for PGO #91259

zooba opened this issue Mar 23, 2022 · 5 comments
Assignees
Labels
3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes build The build process and cross-build OS-windows type-feature A feature request or enhancement

Comments

@zooba
Copy link
Member

zooba commented Mar 23, 2022

BPO 47103
Nosy @pfmoore, @tjguk, @zware, @zooba, @neonene
PRs
  • bpo-47103: Copy pgort140.dll into output directory when building PGInstrument on Windows #32083
  • bpo-47103: Use the copy of pgort140.dll when running test_embed on Windows PGO #32146
  • [3.10] bpo-47103: Copy pgort140.dll into output directory when building PGInstrument on Windows (GH-32083) #32366
  • [3.9] bpo-47103: Copy pgort140.dll into output directory when building PGInstrument on Windows (GH-32083) #32407
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
    closed_at = <Date 2022-04-08.11:04:30.209>
    created_at = <Date 2022-03-23.20:00:21.816>
    labels = ['build', '3.9', '3.10', '3.11', 'type-feature', 'OS-windows']
    title = 'Copy pgort140.dll when building for PGO'
    updated_at = <Date 2022-04-08.11:04:30.208>
    user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2022-04-08.11:04:30.208>
    actor = 'steve.dower'
    assignee = 'steve.dower'
    closed = True
    closed_date = <Date 2022-04-08.11:04:30.209>
    closer = 'steve.dower'
    components = ['Build', 'Windows']
    creation = <Date 2022-03-23.20:00:21.816>
    creator = 'steve.dower'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 47103
    keywords = ['patch']
    message_count = 5.0
    messages = ['415905', '416854', '416908', '416947', '416952']
    nosy_count = 5.0
    nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'neonene']
    pr_nums = ['32083', '32146', '32366', '32407']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue47103'
    versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    @zooba
    Copy link
    Member Author

    zooba commented Mar 23, 2022

    Rather than trying to set up PATH properly, we should just copy pgort140.dll into the build directory when building instrumented version.

    This becomes more important for those (i.e. me) building and then manually running the profile stage on a different machine.

    @zooba zooba added the 3.11 bug and security fixes label Mar 23, 2022
    @zooba zooba self-assigned this Mar 23, 2022
    @zooba zooba added build The build process and cross-build OS-windows type-feature A feature request or enhancement 3.11 bug and security fixes labels Mar 23, 2022
    @zooba zooba self-assigned this Mar 23, 2022
    @zooba zooba added build The build process and cross-build OS-windows type-feature A feature request or enhancement labels Mar 23, 2022
    @zooba
    Copy link
    Member Author

    zooba commented Apr 6, 2022

    New changeset 074da78 by Steve Dower in branch 'main':
    bpo-47103: Copy pgort140.dll into output directory when building PGInstrument on Windows (GH-32083)
    074da78

    @zooba
    Copy link
    Member Author

    zooba commented Apr 6, 2022

    Backport is blocked on bpo-47104 (or a randomly successful CI run, which seems to occur occasionally).

    @zooba zooba added 3.9 only security fixes 3.10 only security fixes labels Apr 6, 2022
    @zooba
    Copy link
    Member Author

    zooba commented Apr 7, 2022

    New changeset b0ec17b by Steve Dower in branch '3.10':
    bpo-47103: Copy pgort140.dll into output directory when building PGInstrument on Windows (GH-32083)
    b0ec17b

    @zooba
    Copy link
    Member Author

    zooba commented Apr 8, 2022

    New changeset 80c1153 by Steve Dower in branch '3.9':
    bpo-47103: Copy pgort140.dll into output directory when building PGInstrument on Windows (GH-32083)
    80c1153

    @zooba zooba closed this as completed Apr 8, 2022
    @zooba zooba closed this as completed Apr 8, 2022
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.9 only security fixes 3.10 only security fixes 3.11 bug and security fixes build The build process and cross-build OS-windows type-feature A feature request or enhancement
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant