Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize call for c functions with METH_FASTCALL|METH_KEYWORDS #91283

Closed
kumaraditya303 opened this issue Mar 26, 2022 · 2 comments
Closed
Labels
3.11 bug and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@kumaraditya303
Copy link
Contributor

BPO 47127
Nosy @markshannon, @sweeneyde, @Fidget-Spinner, @kumaraditya303
PRs
  • bpo-47127: Specialize calls for fastcall c functions with keywords #32125
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2022-03-30.10:55:06.321>
    created_at = <Date 2022-03-26.12:16:33.808>
    labels = ['interpreter-core', '3.11', 'performance']
    title = 'Specialize call for c functions with METH_FASTCALL|METH_KEYWORDS'
    updated_at = <Date 2022-03-30.10:55:06.320>
    user = 'https://github.com/kumaraditya303'

    bugs.python.org fields:

    activity = <Date 2022-03-30.10:55:06.320>
    actor = 'kumaraditya'
    assignee = 'none'
    closed = True
    closed_date = <Date 2022-03-30.10:55:06.321>
    closer = 'kumaraditya'
    components = ['Interpreter Core']
    creation = <Date 2022-03-26.12:16:33.808>
    creator = 'kumaraditya'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 47127
    keywords = []
    message_count = 2.0
    messages = ['416058', '416134']
    nosy_count = 4.0
    nosy_names = ['Mark.Shannon', 'Dennis Sweeney', 'kj', 'kumaraditya']
    pr_nums = ['32125']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'performance'
    url = 'https://bugs.python.org/issue47127'
    versions = ['Python 3.11']

    @kumaraditya303
    Copy link
    Contributor Author

    Specialize call for c functions with METH_FASTCALL|METH_KEYWORDS flags.

    It is the second largest PRECALL specialization failure as per the stats.

    See https://github.com/faster-cpython/ideas/blob/main/stats.md#specialization-attempts-10

    @kumaraditya303 kumaraditya303 added 3.11 bug and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage labels Mar 26, 2022
    @Fidget-Spinner
    Copy link
    Member

    New changeset 58448cb by Kumar Aditya in branch 'main':
    bpo-47127: Specialize calls for fastcall c methods with keywords (GH-32125)
    58448cb

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 bug and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants