Stable ABI: Some optional (#ifdef'd) functions aren't handled correctly

[encukou]

BPO	47169
Nosy	@encukou, @kulikjak
PRs	bpo-47169: Add feature macro PY_HAVE_THREAD_NATIVE_ID to the stable ABI definition #32365 bpo-47169: Export PyOS_CheckStack in the Windows stable ABI DLL #32414

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2022-03-30.15:52:37.045>
labels = ['expert-C-API']
title = "Stable ABI: Some optional (#ifdef'd) functions aren't handled correctly"
updated_at = <Date 2022-04-08.12:49:59.275>
user = 'https://github.com/encukou'

bugs.python.org fields:

activity = <Date 2022-04-08.12:49:59.275>
actor = 'petr.viktorin'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['C API']
creation = <Date 2022-03-30.15:52:37.045>
creator = 'petr.viktorin'
dependencies = []
files = []
hgrepos = []
issue_num = 47169
keywords = ['patch']
message_count = 2.0
messages = ['416377', '416477']
nosy_count = 2.0
nosy_names = ['petr.viktorin', 'kulikjak']
pr_nums = ['32365', '32414']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue47169'
versions = []

Linked PRs

• gh-91325: Skip Stable ABI checks with Py_TRACE_REFS special build #92046

[encukou]

• PyThread_get_thread_native_id is only available when PY_HAVE_THREAD_NATIVE_ID is defined. The test currently always expects it to be available.
• PyOS_CheckStack is only available when USE_STACKCHECK is defined (i.e. on Windows). It should be exported from the DLL.

I plan to:

• add the appropriate metadata
• improve handling & testing of such optional functions in general

[kulikjak]

Solaris is affected by missing PyThread_get_thread_native_id; all other symbols from the SYMBOL_NAMES tuple (in test_stable_abi_ctypes.py) are available.

[encukou]

Reopening: PyModule_Create2 and PyModule_FromDefAndSpec2 are still missing with Py_TRACE_REFS. See Victor's comment: #88299 (comment)

[encukou]

PR for skipping checks on Py_TRACE_REFS builds: #92046

[encukou]

It took a while, but, the exceptions are gone now.