Skip to content

Conversation

@miss-islington
Copy link
Contributor

(cherry picked from commit 2cb1a68)

Co-authored-by: Bar Harel bar.harel@biocatch.com

…n leaked tasks (pythonGH-27765)

(cherry picked from commit 2cb1a68)

Co-authored-by: Bar Harel <bar.harel@biocatch.com>
@ghost
Copy link

ghost commented Apr 12, 2022

Commit authors are required to sign the Contributor License Agreement.
CLA not signed

@zware zware changed the title [3.9] bpo-44911: Fixed IsolatedAsyncioTestCase from throwing an exception on leaked tasks (GH-27765) [3.9] GH-89074: Fixed IsolatedAsyncioTestCase from throwing an exception on leaked tasks (GH-27765) Apr 12, 2022
@miss-islington
Copy link
Contributor Author

@bharel and @ambv: Status check is done, and it's a failure ❌ .

@bharel
Copy link
Contributor

bharel commented Apr 12, 2022

@zware might have committed it using my work instead of personal email, both are under my GitHub account. I have the CLA signed of course.

@zware
Copy link
Member

zware commented Apr 12, 2022

As this is a direct backport of GH-27765 by @miss-islington and the CLA check was satisfied there, I'm ignoring the CLA check here and merging. @ambv may be interested in seeing what happened with it, though :)

@zware zware merged commit 4cc4fe2 into python:3.9 Apr 12, 2022
@bedevere-bot
Copy link

@zware: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington miss-islington deleted the backport-2cb1a68-3.9 branch April 12, 2022 04:14
@bharel
Copy link
Contributor

bharel commented Apr 12, 2022

@zware actually it is quite peculiar: CLA check is not mentioned at all on the main PR, passes on the 3.10 branch but fails on the 3.9.

Edit: looks like it might be the new GitHub pipeline causing an issue.

@zware
Copy link
Member

zware commented Apr 12, 2022

The CLA check passed on both the main PR and 3.10 backport; both have the CLA Signed label added by @the-knights-who-say-ni. However, the knights have been replaced as part of the migration to GitHub issues, and we've just found some manner of edge case in the new CLA check here :)

hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…exception on leaked tasks (pythonGH-27765) (python#91471)

(cherry picked from commit 2cb1a68)

Co-authored-by: Bar Harel <bar.harel@biocatch.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants