-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
gh-84747: Add async for comment for StreamReader #98633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
JelleZijlstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can merge this if @kumaraditya303 is happy.
|
Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
) (cherry picked from commit 4196ee5) Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
|
GH-98690 is a backport of this pull request to the 3.11 branch. |
|
GH-98691 is a backport of this pull request to the 3.10 branch. |
) (cherry picked from commit 4196ee5) Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
https://docs.python.org/dev/library/asyncio-stream.html#asyncio.StreamReader
Perhaps the example under https://docs.python.org/dev/library/asyncio-stream.html#tcp-echo-client-using-streams can be adjusted to look like
but it's optional
async for line in readeris not documented #84747